From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@amd.com>
Cc: meta-virtualization@lists.yoctoproject.org,
mark.hatle@kernel.crashing.org
Subject: Re: [meta-virtualization][master][scathgap][PATCH] device-tree: Rename EXTRA_OVERLAYS to EXTRA_DT_INCLUDE_FILES
Date: Mon, 30 Sep 2024 18:43:18 +0000 [thread overview]
Message-ID: <ZvrxRiQoiRmJCVmx@gmail.com> (raw)
In-Reply-To: <20240928000622.586832-1-sandeep.gundlupet-raju@amd.com>
In message: [meta-virtualization][master][scathgap][PATCH] device-tree: Rename EXTRA_OVERLAYS to EXTRA_DT_INCLUDE_FILES
on 27/09/2024 Sandeep Gundlupet Raju wrote:
> Rename EXTRA_OVERLAYS to EXTRA_DT_INCLUDE_FILES as these variables
> are renamed in device-tree recipe.
Which device tree recipe is that ? We should include a link to that
base recipe in this commit, so that others will know which one we
are tracking.
I checked meta-virt and OE-core and didn't see any variable renames.
Other than that, no concerns with this patch.
Bruce
>
> Signed-off-by: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@amd.com>
> ---
> .../device-tree/device-tree.bbappend | 20 +++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/dynamic-layers/xilinx/recipes-bsp/device-tree/device-tree.bbappend b/dynamic-layers/xilinx/recipes-bsp/device-tree/device-tree.bbappend
> index e235826..813c08f 100644
> --- a/dynamic-layers/xilinx/recipes-bsp/device-tree/device-tree.bbappend
> +++ b/dynamic-layers/xilinx/recipes-bsp/device-tree/device-tree.bbappend
> @@ -3,17 +3,17 @@ FILESEXTRAPATHS:prepend := "${THISDIR}/files:"
> ENABLE_XEN_DTSI ?= ""
> ENABLE_XEN_QEMU_DTSI ?= ""
>
> -XEN_EXTRA_OVERLAYS = ""
> -XEN_EXTRA_QEMU_OVERLAYS = ""
> +XEN_EXTRA_DT_INCLUDE_FILES = ""
> +XEN_EXTRA_QEMU_DT_INCLUDE_FILES = ""
>
> -XEN_EXTRA_OVERLAYS:zynqmp = "zynqmp-xen.dtsi"
> -XEN_EXTRA_QEMU_OVERLAYS:zynqmp = "zynqmp-xen.dtsi zynqmp-xen-qemu.dtsi"
> +XEN_EXTRA_DT_INCLUDE_FILES:zynqmp = "zynqmp-xen.dtsi"
> +XEN_EXTRA_QEMU_DT_INCLUDE_FILES:zynqmp = "zynqmp-xen.dtsi zynqmp-xen-qemu.dtsi"
>
> -XEN_EXTRA_OVERLAYS:versal = "versal-xen.dtsi"
> -XEN_EXTRA_QEMU_OVERLAYS:versal = "versal-xen.dtsi versal-xen-qemu.dtsi"
> +XEN_EXTRA_DT_INCLUDE_FILES:versal = "versal-xen.dtsi"
> +XEN_EXTRA_QEMU_DT_INCLUDE_FILES:versal = "versal-xen.dtsi versal-xen-qemu.dtsi"
>
> -XEN_EXTRA_OVERLAYS:versal-net = "versal-net-xen.dtsi"
> -XEN_EXTRA_QEMU_OVERLAYS:versal-net = "versal-net-xen.dtsi versal-net-xen-qemu.dtsi"
> +XEN_EXTRA_DT_INCLUDE_FILES:versal-net = "versal-net-xen.dtsi"
> +XEN_EXTRA_QEMU_DT_INCLUDE_FILES:versal-net = "versal-net-xen.dtsi versal-net-xen-qemu.dtsi"
>
> -EXTRA_OVERLAYS:append = "${@' ${XEN_EXTRA_OVERLAYS}' if d.getVar('ENABLE_XEN_DTSI') == '1' else ''}"
> -EXTRA_OVERLAYS:append = "${@' ${XEN_EXTRA_QEMU_OVERLAYS}' if d.getVar('ENABLE_XEN_QEMU_DTSI') == '1' else ''}"
> +EXTRA_DT_INCLUDE_FILES:append = "${@' ${XEN_EXTRA_DT_INCLUDE_FILES}' if d.getVar('ENABLE_XEN_DTSI') == '1' else ''}"
> +EXTRA_DT_INCLUDE_FILES:append = "${@' ${XEN_EXTRA_QEMU_DT_INCLUDE_FILES}' if d.getVar('ENABLE_XEN_QEMU_DTSI') == '1' else ''}"
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-09-30 18:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-28 0:06 [meta-virtualization][master][scathgap][PATCH] device-tree: Rename EXTRA_OVERLAYS to EXTRA_DT_INCLUDE_FILES Sandeep Gundlupet Raju
2024-09-30 18:43 ` Bruce Ashfield [this message]
2024-10-01 19:45 ` Gundlupet Raju, Sandeep
2024-10-01 20:29 ` Bruce Ashfield
2024-10-01 20:30 ` Gundlupet Raju, Sandeep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvrxRiQoiRmJCVmx@gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=mark.hatle@kernel.crashing.org \
--cc=meta-virtualization@lists.yoctoproject.org \
--cc=sandeep.gundlupet-raju@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.