Re: [PATCH v4] Input: Add driver for PixArt PS/2 touchpad

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Tue, Oct 01, 2024 at 01:53:44AM -0700, Dmitry Torokhov wrote:
> On Mon, Sep 30, 2024 at 05:59:01PM +0200, Benjamin Tissoires wrote:
> > Hi,
> > 
> > On Jul 04 2024, Binbin Zhou wrote:
> > > This patch introduces a driver for the PixArt PS/2 touchpad, which
> > > supports both clickpad and touchpad types.
> > > 
> > > At the same time, we extended the single data packet length to 16,
> > > because according to the current PixArt hardware and FW design, we need
> > > 11 bytes/15 bytes to represent the complete three-finger/four-finger data.
> > > 
> > > Co-developed-by: Jon Xie <jon_xie@pixart.com>
> > > Signed-off-by: Jon Xie <jon_xie@pixart.com>
> > > Co-developed-by: Jay Lee <jay_lee@pixart.com>
> > > Signed-off-by: Jay Lee <jay_lee@pixart.com>
> > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> > 
> > It looks like this new driver made in v6.12-rc1 but is already breaking
> > other touchpads in fedora:
> > 
> > https://bugzilla.redhat.com/show_bug.cgi?id=2314756
> > 
> > The reported touchpads used to work properly but are now directed to use
> > the PixArt PS2 driver instead of the old one (I would say it should be
> > using Synaptics).
> > 
> > I haven't touched PS/2 in a long time, so it's going to be hard to
> > pinpoint the error from my side, but it seems that the new driver is a
> > little bit too greedy.
> 
> OK, I gonna revert it and hope PixArt folks will figure out less greedy
> probing sequence (or maybe we need to push it down a few sports).

Although, as I am trying to read the referenced bug, one of the
reporters are saying that they touchpad is USB:

SysFS ID: /devices/pci0000:00/0000:00:14.0/usb3/3-3/3-3:1.0
ysFS BusID: 3-3:1.0
Hardware Class: unknown
Model: "Synaptics Unclassified device"
Hotplug: USB
Vendor: usb 0x06cb "Synaptics, Inc."

so I am not sure how PS/2 device would interfere with that.

Could you give me access to the attachments on the bug so I can take a
closer look? And hopefully the original reporter will submit their data.

Thanks.

-- 
Dmitry