From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
amadeuszx.slawinski@linux.intel.com,
Tony Nguyen <anthony.l.nguyen@intel.com>,
nex.sw.ncis.osdt.itp.upstreaming@intel.com,
netdev@vger.kernel.org, Markus Elfring <Markus.Elfring@web.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [RFC PATCH v2] Simply enable one to write code like:
Date: Tue, 1 Oct 2024 18:09:00 +0300 [thread overview]
Message-ID: <ZvwQjMwdDVviQL2P@smile.fi.intel.com> (raw)
In-Reply-To: <20241001145718.8962-1-przemyslaw.kitszel@intel.com>
On Tue, Oct 01, 2024 at 04:57:18PM +0200, Przemek Kitszel wrote:
...
> NAKed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
And still NAKed.
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> ---
> Andy believes that this change is completely wrong C, the reasons
> (that I disagree with of course, are in v1, below the commit message).
Have you retested the macro expansion for this version?
...
> */
>
> +
Too many blank lines.
> +#define DEFINE_CLASS_IS_CONDITIONAL(_name, _is_cond) \
> +static __maybe_unused const bool class_##_name##_is_conditional = _is_cond
...
> + DEFINE_CLASS_IS_CONDITIONAL(_name, 0); \
Here and everywhere else, boolean has values true and false.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-01 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 14:57 [RFC PATCH v2] Simply enable one to write code like: Przemek Kitszel
2024-10-01 15:09 ` Andy Shevchenko [this message]
2024-10-02 8:07 ` Przemek Kitszel
2024-10-01 15:21 ` Dmitry Torokhov
2024-10-02 9:55 ` Przemek Kitszel
2024-10-01 15:29 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvwQjMwdDVviQL2P@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Markus.Elfring@web.de \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=peterz@infradead.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.