From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Jose Abreu <joabreu@synopsys.com>,
Jose Abreu <Jose.Abreu@synopsys.com>,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <olteanv@gmail.com>
Subject: [PATCH net-next 00/10] net: pcs: xpcs: cleanups batch 1
Date: Tue, 1 Oct 2024 17:02:48 +0100 [thread overview]
Message-ID: <ZvwdKIp3oYSenGdH@shell.armlinux.org.uk> (raw)
Hi,
First, sorry for the bland series subject - this is the first in a
number of cleanup series to the XPCS driver. This series has some
functional changes beyond merely cleanups, notably the first patch.
This series starts off with a patch that moves the PCS reset from
the xpcs_create*() family of calls to when phylink first configures
the PHY. The motivation for this change is to get rid of the
interface argument to the xpcs_create*() functions, which I see as
unnecessary complexity. This patch should be tested on Wangxun
and STMMAC drivers.
Patch 2 removes the now unnecessary interface argument from the
internal xpcs_create() and xpcs_init_iface() functions. With this,
xpcs_init_iface() becomes a misnamed function, but patch 3 removes
this function, moving its now meager contents to xpcs_create().
Patch 4 adds xpcs_destroy_pcs() and xpcs_create_pcs_mdiodev()
functions which return and take a phylink_pcs, allowing SJA1105
and Wangxun drivers to be converted to using the phylink_pcs
structure internally.
Patches 5 through 8 convert both these drivers to that end.
Patch 9 drops the interface argument from the remaining xpcs_create*()
functions, addressing the only remaining caller of these functions,
that being the STMMAC driver.
As patch 7 removed the direct calls to the XPCS config/link-up
functions, the last patch makes these functions static.
drivers/net/dsa/sja1105/sja1105.h | 2 +-
drivers/net/dsa/sja1105/sja1105_main.c | 85 ++++++++++----------
drivers/net/dsa/sja1105/sja1105_mdio.c | 28 ++++---
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 7 +-
drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c | 18 ++---
drivers/net/ethernet/wangxun/txgbe/txgbe_type.h | 2 +-
drivers/net/pcs/pcs-xpcs.c | 92 ++++++++++++++---------
include/linux/pcs/pcs-xpcs.h | 14 ++--
8 files changed, 132 insertions(+), 116 deletions(-)
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next reply other threads:[~2024-10-01 16:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 16:02 Russell King (Oracle) [this message]
2024-10-01 16:04 ` [PATCH net-next 01/10] net: pcs: xpcs: move PCS reset to .pcs_pre_config() Russell King (Oracle)
2024-10-01 20:34 ` Serge Semin
2024-10-01 22:01 ` Russell King (Oracle)
2024-10-01 22:09 ` Andrew Lunn
2024-10-02 22:56 ` Serge Semin
2024-10-02 23:12 ` Andrew Lunn
2024-10-02 23:43 ` Serge Semin
2024-10-03 0:04 ` Andrew Lunn
2024-10-03 8:58 ` Russell King (Oracle)
2024-10-03 23:39 ` Serge Semin
2024-10-02 23:25 ` Russell King (Oracle)
2024-10-01 16:04 ` [PATCH net-next 02/10] net: pcs: xpcs: drop interface argument from internal functions Russell King (Oracle)
2024-10-01 16:04 ` [PATCH net-next 03/10] net: pcs: xpcs: get rid of xpcs_init_iface() Russell King (Oracle)
2024-10-01 16:04 ` [PATCH net-next 04/10] net: pcs: xpcs: add xpcs_destroy_pcs() and xpcs_create_pcs_mdiodev() Russell King (Oracle)
2024-10-01 16:04 ` [PATCH net-next 05/10] net: wangxun: txgbe: use phylink_pcs internally Russell King (Oracle)
2024-10-01 22:12 ` Andrew Lunn
2024-10-01 16:04 ` [PATCH net-next 06/10] net: dsa: sja1105: simplify static configuration reload Russell King (Oracle)
2024-10-01 16:04 ` [PATCH net-next 07/10] net: dsa: sja1105: call PCS config/link_up via pcs_ops structure Russell King (Oracle)
2024-10-01 16:04 ` [PATCH net-next 08/10] net: dsa: sja1105: use phylink_pcs internally Russell King (Oracle)
2024-10-01 16:04 ` [PATCH net-next 09/10] net: pcs: xpcs: drop interface argument from xpcs_create*() Russell King (Oracle)
2024-10-01 16:04 ` [PATCH net-next 10/10] net: pcs: xpcs: make xpcs_do_config() and xpcs_link_up() internal Russell King (Oracle)
2024-10-03 0:40 ` [PATCH net-next 00/10] net: pcs: xpcs: cleanups batch 1 patchwork-bot+netdevbpf
2024-10-04 23:29 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvwdKIp3oYSenGdH@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jiawenwu@trustnetic.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.