From: Oliver Upton <oliver.upton@linux.dev>
To: Marc Zyngier <maz@kernel.org>
Cc: kvmarm@lists.linux.dev, Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>
Subject: Re: [PATCH 3/3] KVM: arm64: nv: Punt stage-2 recycling to a vCPU request
Date: Tue, 1 Oct 2024 17:06:58 -0700 [thread overview]
Message-ID: <ZvyOovRpxoQtPvZj@linux.dev> (raw)
In-Reply-To: <86ed4z76gw.wl-maz@kernel.org>
On Wed, Oct 02, 2024 at 12:23:43AM +0100, Marc Zyngier wrote:
> > +
> > +void check_nested_vcpu_requests(struct kvm_vcpu *vcpu)
> > +{
> > + if (kvm_check_request(KVM_REQ_NESTED_S2_UNMAP, vcpu)) {
> > + CLASS(vcpu_hw_mmu, mmu)(vcpu);
>
> I really think a small comment outlining *why* we need to elevate the
> refcount would help. This single line is what holds the whole thing
> together.
Sure, it is only _slightly_ load bearing...
--
Thanks,
Oliver
prev parent reply other threads:[~2024-10-02 0:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 0:17 [PATCH 0/3] KVM: arm64: nv: Fixes for stage-2 MMU recycling Oliver Upton
2024-10-01 0:17 ` [PATCH 1/3] KVM: arm64: Treat stage-2 MMUs as refcounted generally Oliver Upton
2024-10-01 0:17 ` [PATCH 2/3] KVM: arm64: nv: Do not block when unmapping stage-2 if disallowed Oliver Upton
2024-10-01 0:17 ` [PATCH 3/3] KVM: arm64: nv: Punt stage-2 recycling to a vCPU request Oliver Upton
2024-10-01 19:05 ` Sean Christopherson
2024-10-01 20:41 ` Oliver Upton
2024-10-01 23:28 ` Sean Christopherson
2024-10-01 23:49 ` Marc Zyngier
2024-10-02 0:06 ` Oliver Upton
2024-10-02 0:23 ` Sean Christopherson
2024-10-02 23:31 ` Marc Zyngier
2024-10-03 0:04 ` Oliver Upton
2024-10-03 0:12 ` Oliver Upton
2024-10-03 16:45 ` Sean Christopherson
2024-10-03 17:52 ` Oliver Upton
2024-10-03 18:23 ` Sean Christopherson
2024-10-03 22:03 ` Oliver Upton
2024-10-01 23:23 ` Marc Zyngier
2024-10-02 0:06 ` Oliver Upton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvyOovRpxoQtPvZj@linux.dev \
--to=oliver.upton@linux.dev \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.