Re: [PATCH v4] perf test stat_all_pmu.sh: Parse return value of perf stat

[Namhyung Kim <namhyung@kernel.org>]

On Tue, Oct 01, 2024 at 05:25:55PM -0700, Namhyung Kim wrote:
> On Tue, Oct 01, 2024 at 10:35:33AM +0200, Veronika Molnarova wrote:
> > 
> > 
> > On 8/14/24 19:01, vmolnaro@redhat.com wrote:
> > > From: Veronika Molnarova <vmolnaro@redhat.com>
> > > 
> > > With the upstream MR !3916 of commit ad86d7ee43b22aa2 ('powerpc/hv-gpci:
> > > Fix the H_GET_PERF_COUNTER_INFO hcall return value checks') the perf
> > > stat for hv_gpci events without required permission set returns an
> > > error value of -1 to differentiate the output from the unsupported
> > > events. The stat_all_pmu test was designed in a way, that if any
> > > command exits with a non-zero value the test exits with an error
> > > value without any information provided due to the 'set -e' option.
> > > 
> > > The issue propagated upstream as the list of the files that affected perf
> > > did not cover the changed files and was updated after the issue was
> > > discovered. It was caught by CKI testing where it was triaged to stop
> > > blocking further MRs, as most of the powerpc machines have some of
> > > the hv_gpci events without the required permissions.
> > > 
> > > Remove the 'set -e' option from the test and rework the test case to log
> > > the status of the event for better maintainability. Instead of exiting
> > > immediately after 'perf stat' ends with a non-zero value, check the
> > > return value and output of the 'perf stat' command with the appropriate action.
> > > 
> > > Link to the MR !3916 of commit ad86d7ee43b22aa2:
> > > https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9/-/merge_requests/3916
> > > 
> > > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> > > Cc: Jiri Olsa <jolsa@kernel.org>
> > > Cc: Mark Rutland <mark.rutland@arm.com>
> > > Cc: Michael Petlan <mpetlan@redhat.com>
> > > Cc: Radostin Stoyanov <rstoyano@redhat.com>
> > > Signed-off-by: Veronika Molnarova <vmolnaro@redhat.com>

Also, please collect reviewers' tags in the previous versions like
Reviewed-by and Tested-by from Kajol Jain.

Thanks,
Namhyung