From: Andy Shevchenko <andy@kernel.org>
To: Philipp Stanner <pstanner@redhat.com>
Cc: "Alvaro Karsz" <alvaro.karsz@solid-run.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH RESEND] vdpa: solidrun: Fix UB bug with devres
Date: Wed, 16 Oct 2024 12:08:57 +0300 [thread overview]
Message-ID: <Zw-CqayFcWzOwci_@smile.fi.intel.com> (raw)
In-Reply-To: <20241016072553.8891-2-pstanner@redhat.com>
On Wed, Oct 16, 2024 at 09:25:54AM +0200, Philipp Stanner wrote:
> In psnet_open_pf_bar() and snet_open_vf_bar() a string later passed to
> pcim_iomap_regions() is placed on the stack. Neither
> pcim_iomap_regions() nor the functions it calls copy that string.
>
> Should the string later ever be used, this, consequently, causes
> undefined behavior since the stack frame will by then have disappeared.
>
> Fix the bug by allocating the strings on the heap through
> devm_kasprintf().
> ---
I haven't found the reason for resending. Can you elaborate here?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-16 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 7:25 [PATCH RESEND] vdpa: solidrun: Fix UB bug with devres Philipp Stanner
2024-10-16 9:08 ` Andy Shevchenko [this message]
2024-10-16 9:22 ` Philipp Stanner
2024-10-16 10:22 ` Andy Shevchenko
2024-10-16 10:51 ` Greg KH
2024-10-16 11:16 ` Philipp Stanner
2024-10-16 15:08 ` Greg KH
2024-10-18 14:49 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw-CqayFcWzOwci_@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=alvaro.karsz@solid-run.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pstanner@redhat.com \
--cc=stable@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.