From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <olteanv@gmail.com>
Subject: [PATCH net-next v2 0/5] Removing more phylink cruft
Date: Wed, 16 Oct 2024 10:57:29 +0100 [thread overview]
Message-ID: <Zw-OCSv7SldjB7iU@shell.armlinux.org.uk> (raw)
Hi,
Continuing on with the cleanups, this patch series removes
dsa_port_phylink_mac_select_pcs() which is no longer required. This
will have no functional effect as phylink does this:
bool using_mac_select_pcs = false;
if (mac_ops->mac_select_pcs &&
mac_ops->mac_select_pcs(config, PHY_INTERFACE_MODE_NA) !=
ERR_PTR(-EOPNOTSUPP))
using_mac_select_pcs = true;
and no mac_select_pcs() method is equivalent to a mac_select_pcs()
that returns -EOPNOTSUPP.
We then make mv88e6xxx_mac_select_pcs() return NULL, as we don't want
to invoke this old behaviour anymore - mv88e6xxx doesn't require it.
Then, allow phylink to remove PCS, which has been a long standing
behavioural oddity.
Remove the use of pl->pcs when validating as this will never be
non-NULL unless "using_mac_select_pcs" was set.
This then clears the way to removing using_mac_select_pcs from phylink
and the check.
drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
drivers/net/phy/phylink.c | 18 +++-----------
net/dsa/port.c | 8 --------
3 files changed, 5 insertions(+), 23 deletions(-)
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next reply other threads:[~2024-10-16 9:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 9:57 Russell King (Oracle) [this message]
2024-10-16 9:58 ` [PATCH net-next v2 1/5] net: dsa: remove dsa_port_phylink_mac_select_pcs() Russell King (Oracle)
2024-10-16 9:58 ` [PATCH net-next v2 2/5] net: dsa: mv88e6xxx: return NULL when no PCS is present Russell King (Oracle)
2024-10-16 9:58 ` [PATCH net-next v2 3/5] net: phylink: allow mac_select_pcs() to remove a PCS Russell King (Oracle)
2024-10-17 7:00 ` Vladimir Oltean
2024-10-16 9:58 ` [PATCH net-next v2 4/5] net: phylink: remove use of pl->pcs in phylink_validate_mac_and_pcs() Russell King (Oracle)
2024-10-17 7:01 ` Vladimir Oltean
2024-10-16 9:58 ` [PATCH net-next v2 5/5] net: phylink: remove "using_mac_select_pcs" Russell King (Oracle)
2024-10-17 7:06 ` Vladimir Oltean
2024-10-16 14:42 ` [PATCH net-next v2 0/5] Removing more phylink cruft Maxime Chevallier
2024-10-18 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw-OCSv7SldjB7iU@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.