From: Andy Shevchenko <andy@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] media: atomisp: remove redundant re-checking of err
Date: Mon, 14 Oct 2024 14:34:14 +0300 [thread overview]
Message-ID: <Zw0Btri2dydmt3W3@smile.fi.intel.com> (raw)
In-Reply-To: <20241012141403.1558513-1-colin.i.king@gmail.com>
On Sat, Oct 12, 2024 at 03:14:03PM +0100, Colin Ian King wrote:
> The check to see if err is non-zero is always false because err has
> been previously checked on whenever err has been assigned in previous
> code paths. The check is redundant and can be removed.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
All patches that end up in 100% minus lines statistics for this driver are so good!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-14 11:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 14:14 [PATCH] media: atomisp: remove redundant re-checking of err Colin Ian King
2024-10-14 11:34 ` Andy Shevchenko [this message]
2024-11-04 12:01 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw0Btri2dydmt3W3@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.