From: Vinod Koul <vkoul@kernel.org>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>,
dmaengine@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: idxd: Move DSA/IAA device IDs to IDXD driver
Date: Mon, 14 Oct 2024 23:47:19 +0530 [thread overview]
Message-ID: <Zw1gL22McDhFfgnk@vaman> (raw)
In-Reply-To: <20241004195200.3398664-1-fenghua.yu@intel.com>
On 04-10-24, 12:52, Fenghua Yu wrote:
> Since the DSA/IAA device IDs are only used by the IDXD driver, there is
> no need to define them as public IDs. Move their definitions to the IDXD
> driver to limit their scope. This change helps reduce unnecessary
> exposure of the device IDs in the global space, making the codebase
> cleaner and better encapsulated.
That is good
>
> There is no functional change.
Ok
>
> Fixes: 4fecf944c051 ("dmaengine: idxd: Add new DSA and IAA device IDs for Diamond Rapids platform")
> Fixes: f91f2a9879cc ("dmaengine: idxd: Add a new DSA device ID for Granite Rapids-D platform")
How is this a fix?
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> ---
> drivers/dma/idxd/registers.h | 4 ++++
> include/linux/pci_ids.h | 3 ---
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/idxd/registers.h b/drivers/dma/idxd/registers.h
> index e16dbf9ab324..c426511f2104 100644
> --- a/drivers/dma/idxd/registers.h
> +++ b/drivers/dma/idxd/registers.h
> @@ -6,6 +6,10 @@
> #include <uapi/linux/idxd.h>
>
> /* PCI Config */
> +#define PCI_DEVICE_ID_INTEL_DSA_GNRD 0x11fb
> +#define PCI_DEVICE_ID_INTEL_DSA_DMR 0x1212
> +#define PCI_DEVICE_ID_INTEL_IAA_DMR 0x1216
> +
> #define DEVICE_VERSION_1 0x100
> #define DEVICE_VERSION_2 0x200
>
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 4cf6aaed5f35..e4bddb927795 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2709,9 +2709,6 @@
> #define PCI_DEVICE_ID_INTEL_82815_MC 0x1130
> #define PCI_DEVICE_ID_INTEL_82815_CGC 0x1132
> #define PCI_DEVICE_ID_INTEL_SST_TNG 0x119a
> -#define PCI_DEVICE_ID_INTEL_DSA_GNRD 0x11fb
> -#define PCI_DEVICE_ID_INTEL_DSA_DMR 0x1212
> -#define PCI_DEVICE_ID_INTEL_IAA_DMR 0x1216
> #define PCI_DEVICE_ID_INTEL_82092AA_0 0x1221
> #define PCI_DEVICE_ID_INTEL_82437 0x122d
> #define PCI_DEVICE_ID_INTEL_82371FB_0 0x122e
> --
> 2.37.1
--
~Vinod
next prev parent reply other threads:[~2024-10-14 18:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 19:52 [PATCH] dmaengine: idxd: Move DSA/IAA device IDs to IDXD driver Fenghua Yu
2024-10-14 18:17 ` Vinod Koul [this message]
2024-10-14 19:13 ` Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw1gL22McDhFfgnk@vaman \
--to=vkoul@kernel.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.