From: Taylor Blau <me@ttaylorr.com>
To: Luca Milanesio <luca.milanesio@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Martin Fick <mfick@nvidia.com>
Subject: Re: Should object repacking only update server-info for packs instead of doing it for refs?
Date: Mon, 14 Oct 2024 17:25:42 -0400 [thread overview]
Message-ID: <Zw2MVqi0FLcMuR8Z@nand.local> (raw)
In-Reply-To: <569E3AEA-AC68-4186-B38C-2E47DAB9890E@gmail.com>
On Mon, Oct 14, 2024 at 09:33:17PM +0100, Luca Milanesio wrote:
> > It seems counterintuitive that an operation designed to repack
> > objects would be performing maintenance of any sort on refs?
>
> True, it should not touch info/refs IMHO, as you’re really not
> changing any refs.
Right. I don't think that the current behavior is a bug, but just that
it's doing unnecessary work from within 'git repack' to update the
info/refs file when it's known ahead of time that the refs haven't
changed.
I think it's reasonable to skip this step when repacking, but of course
we would still want to update info/packs (assuming that the repack
wasn't a noop, of course).
Thanks,
Taylor
next prev parent reply other threads:[~2024-10-14 21:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 20:07 Should object repacking only update server-info for packs instead of doing it for refs? Martin Fick
2024-10-14 20:33 ` Luca Milanesio
2024-10-14 21:25 ` Taylor Blau [this message]
2024-10-15 11:02 ` Patrick Steinhardt
2024-10-15 11:52 ` Luca Milanesio
2024-10-15 12:14 ` Patrick Steinhardt
2024-10-15 13:56 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw2MVqi0FLcMuR8Z@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=luca.milanesio@gmail.com \
--cc=mfick@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.