All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Ed Reel <edreel@gmail.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 0/3] cmake: fix autogenerated clar headers
Date: Mon, 14 Oct 2024 17:40:30 -0400	[thread overview]
Message-ID: <Zw2PzoYBvm59jy51@nand.local> (raw)
In-Reply-To: <cover.1728914219.git.ps@pks.im>

On Mon, Oct 14, 2024 at 04:06:38PM +0200, Patrick Steinhardt wrote:
> Hi,
>
> this small patch series fixes how we set up autogenerated clar headers
> in CMake such that the clar builds again. The underlying issue is that
> we accidentally added the source directory, not the build directory, to
> our list of include directories. I guess this went unnoticed because if
> you also happen to use Makefiles in the same repo, we'd have found the
> Makefile-generated headers by accident.
>
> The other two patches unify the infra to generate "clar-decls.h", which
> has basically been pulled out of my build system modernization patch
> series.
>
> Taylor: note that this conflicts with the patch series at [1]. The
> conflict can be solved by accepting the Makefile of this series here and
> adding the following on top of "t/unit-tests/generate-clar-decls.sh":

Thanks. I had initially kicked the latter out of 'seen' when applying
both to my tree. But when I went back and read the contents of these
patches more carefully I saw your note here, which is very much
appreciated.

Thanks,
Taylor

  parent reply	other threads:[~2024-10-14 21:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09  3:23 Bug report Ed Reel
2024-10-14  6:10 ` Johannes Schindelin
2024-10-14 14:06 ` [PATCH 0/3] cmake: fix autogenerated clar headers Patrick Steinhardt
2024-10-14 14:06   ` [PATCH 1/3] Makefile: extract script to generate clar declarations Patrick Steinhardt
2024-10-14 21:42     ` Taylor Blau
2024-10-15  9:08       ` Patrick Steinhardt
2024-10-14 14:06   ` [PATCH 2/3] cmake: fix compilation of clar-based unit tests Patrick Steinhardt
2024-10-14 21:46     ` Taylor Blau
2024-10-15  9:09       ` Patrick Steinhardt
2024-10-14 14:06   ` [PATCH 3/3] cmake: set up proper dependencies for generated clar headers Patrick Steinhardt
2024-10-14 21:47     ` Taylor Blau
2024-10-14 21:40   ` Taylor Blau [this message]
2024-10-15  9:46 ` [PATCH v2 0/3] cmake: fix autogenerated " Patrick Steinhardt
2024-10-15  9:46   ` [PATCH v2 1/3] Makefile: extract script to generate clar declarations Patrick Steinhardt
2024-10-15 19:24     ` Taylor Blau
2024-10-18 15:21     ` Toon Claes
2024-10-21  6:59       ` Patrick Steinhardt
2024-10-15  9:46   ` [PATCH v2 2/3] cmake: fix compilation of clar-based unit tests Patrick Steinhardt
2024-10-15  9:46   ` [PATCH v2 3/3] cmake: set up proper dependencies for generated clar headers Patrick Steinhardt
2024-10-15 19:25   ` [PATCH v2 0/3] cmake: fix autogenerated " Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zw2PzoYBvm59jy51@nand.local \
    --to=me@ttaylorr.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=edreel@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.