From: Taylor Blau <me@ttaylorr.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 01/10] t/test-lib: fix quoting of TEST_RESULTS_SAN_FILE
Date: Mon, 14 Oct 2024 18:00:35 -0400 [thread overview]
Message-ID: <Zw2Ug71K3FhlC9m2@nand.local> (raw)
In-Reply-To: <601670912eeb80cc599c0e7af4ea87c370ae831d.1728906490.git.ps@pks.im>
On Mon, Oct 14, 2024 at 02:21:12PM +0200, Patrick Steinhardt wrote:
> Properly quote the value to fix the issue while using single-quotes to
> quote the inner value passed to eval. The issue can be reproduced by
> t0000 with such a path that contains spaces.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
> t/test-lib.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index b1a8ee5c002..241198ba95f 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -1572,7 +1572,7 @@ then
>
> prepend_var LSAN_OPTIONS : dedup_token_length=9999
> prepend_var LSAN_OPTIONS : log_exe_name=1
> - prepend_var LSAN_OPTIONS : log_path=\"$TEST_RESULTS_SAN_FILE\"
> + prepend_var LSAN_OPTIONS : log_path="'$TEST_RESULTS_SAN_FILE'"
Makes sense.
Thanks,
Taylor
next prev parent reply other threads:[~2024-10-14 22:00 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 12:21 [PATCH 00/10] Platform compatibility fixes Patrick Steinhardt
2024-10-14 12:21 ` [PATCH 01/10] t/test-lib: fix quoting of TEST_RESULTS_SAN_FILE Patrick Steinhardt
2024-10-14 22:00 ` Taylor Blau [this message]
2024-10-14 12:21 ` [PATCH 02/10] t/test-lib: wire up NO_ICONV prerequisite Patrick Steinhardt
2024-10-14 12:21 ` [PATCH 03/10] t/lib-gitweb: test against the build version of gitweb Patrick Steinhardt
2024-10-14 22:06 ` Taylor Blau
2024-10-15 11:36 ` Patrick Steinhardt
2024-10-14 12:21 ` [PATCH 04/10] t/lib-gpg: fix setup of GNUPGHOME in MinGW Patrick Steinhardt
2024-10-14 22:07 ` Taylor Blau
2024-10-14 12:21 ` [PATCH 05/10] t1401: make invocation of tar(1) work with Win32-provided one Patrick Steinhardt
2024-10-14 23:23 ` Eric Sunshine
2024-10-15 0:29 ` Taylor Blau
2024-10-14 12:21 ` [PATCH 06/10] t3404: work around platform-specific behaviour on macOS 10.15 Patrick Steinhardt
2024-10-14 12:21 ` [PATCH 07/10] t5500, t5601: skip tests which exercise paths with '[::1]' on Cygwin Patrick Steinhardt
2024-10-14 22:10 ` Taylor Blau
2024-10-14 12:21 ` [PATCH 08/10] t7300: work around platform-specific behaviour with long paths on MinGW Patrick Steinhardt
2024-10-14 12:21 ` [PATCH 09/10] builtin/credential-cache: fix missing parameter for stub function Patrick Steinhardt
2024-10-14 22:12 ` Taylor Blau
2024-10-14 12:21 ` [PATCH 10/10] http: fix build error on FreeBSD Patrick Steinhardt
2024-10-14 22:14 ` Taylor Blau
2024-10-15 11:44 ` Patrick Steinhardt
2024-10-15 11:45 ` [PATCH v2 00/10] Platform compatibility fixes Patrick Steinhardt
2024-10-15 11:45 ` [PATCH v2 01/10] t/test-lib: fix quoting of TEST_RESULTS_SAN_FILE Patrick Steinhardt
2024-10-15 11:45 ` [PATCH v2 02/10] t/test-lib: wire up NO_ICONV prerequisite Patrick Steinhardt
2024-10-15 23:53 ` Taylor Blau
2024-10-16 3:57 ` Patrick Steinhardt
2024-10-16 20:59 ` Taylor Blau
2024-10-16 21:02 ` Taylor Blau
2024-10-17 4:03 ` Patrick Steinhardt
2024-10-15 11:45 ` [PATCH v2 03/10] t/lib-gitweb: test against the build version of gitweb Patrick Steinhardt
2024-10-15 11:45 ` [PATCH v2 04/10] t/lib-gpg: fix setup of GNUPGHOME in MinGW Patrick Steinhardt
2024-10-16 5:59 ` James Liu
2024-10-15 11:45 ` [PATCH v2 05/10] t1401: make invocation of tar(1) work with Win32-provided one Patrick Steinhardt
2024-10-16 5:58 ` James Liu
2024-10-15 11:45 ` [PATCH v2 06/10] t3404: work around platform-specific behaviour on macOS 10.15 Patrick Steinhardt
2024-10-16 6:02 ` James Liu
2024-10-15 11:45 ` [PATCH v2 07/10] t5500, t5601: skip tests which exercise paths with '[::1]' on Cygwin Patrick Steinhardt
2024-10-15 11:45 ` [PATCH v2 08/10] t7300: work around platform-specific behaviour with long paths on MinGW Patrick Steinhardt
2024-10-16 6:35 ` James Liu
2024-10-16 8:27 ` James Liu
2024-10-15 11:45 ` [PATCH v2 09/10] builtin/credential-cache: fix missing parameter for stub function Patrick Steinhardt
2024-10-15 11:45 ` [PATCH v2 10/10] http: fix build error on FreeBSD Patrick Steinhardt
2024-10-16 8:12 ` [PATCH v3 00/10] Platform compatibility fixes Patrick Steinhardt
2024-10-16 8:12 ` [PATCH v3 01/10] t/test-lib: fix quoting of TEST_RESULTS_SAN_FILE Patrick Steinhardt
2024-10-16 8:12 ` [PATCH v3 02/10] t/test-lib: wire up NO_ICONV prerequisite Patrick Steinhardt
2024-10-17 1:10 ` brian m. carlson
2024-10-17 4:03 ` Patrick Steinhardt
2024-10-25 18:32 ` Josh Steadmon
2024-10-28 5:14 ` [PATCH] t6006: fix prereq handling with `test_format ()` Patrick Steinhardt
2024-10-28 17:48 ` Taylor Blau
2024-10-16 8:12 ` [PATCH v3 03/10] t/lib-gitweb: test against the build version of gitweb Patrick Steinhardt
2024-10-16 8:12 ` [PATCH v3 04/10] t/lib-gpg: fix setup of GNUPGHOME in MinGW Patrick Steinhardt
2024-10-16 8:13 ` [PATCH v3 05/10] t1401: make invocation of tar(1) work with Win32-provided one Patrick Steinhardt
2024-10-16 8:13 ` [PATCH v3 06/10] t3404: work around platform-specific behaviour on macOS 10.15 Patrick Steinhardt
2024-10-16 8:13 ` [PATCH v3 07/10] t5500, t5601: skip tests which exercise paths with '[::1]' on Cygwin Patrick Steinhardt
2024-10-16 8:13 ` [PATCH v3 08/10] t7300: work around platform-specific behaviour with long paths on MinGW Patrick Steinhardt
2024-10-16 8:13 ` [PATCH v3 09/10] builtin/credential-cache: fix missing parameter for stub function Patrick Steinhardt
2024-10-16 8:13 ` [PATCH v3 10/10] http: fix build error on FreeBSD Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw2Ug71K3FhlC9m2@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.