From: Andy Shevchenko <andy@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Nuno Sa" <nuno.sa@analog.com>,
"Olivier Moysan" <olivier.moysan@foss.st.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Ivan Mikhaylov" <fr0st61te@gmail.com>,
"Marius Cristea" <marius.cristea@microchip.com>,
"Dumitru Ceclan" <mitrutzceclan@gmail.com>,
"João Paulo Gonçalves" <joao.goncalves@toradex.com>,
"Alisa-Dariana Roman" <alisadariana@gmail.com>,
"Mike Looijmans" <mike.looijmans@topic.nl>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Sergiu Cuciurean" <sergiu.cuciurean@analog.com>,
"Dragos Bogdan" <dragos.bogdan@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH v3 6/6] iio: adc: ad4851: add ad485x driver
Date: Tue, 15 Oct 2024 14:13:40 +0300 [thread overview]
Message-ID: <Zw5OZAhzyhNUTPae@smile.fi.intel.com> (raw)
In-Reply-To: <c70139f8-c0ba-4e28-9477-964db3fbfbba@baylibre.com>
On Mon, Oct 14, 2024 at 05:08:47PM -0500, David Lechner wrote:
> On 10/14/24 8:14 AM, Andy Shevchenko wrote:
> > On Mon, Oct 14, 2024 at 12:40:40PM +0300, Antoniu Miclaus wrote:
...
> >> + return regmap_update_bits(st->regmap, AD4851_REG_PACKET,
> >> + AD4851_PACKET_FORMAT_MASK, (osr == 1) ? 0 : 1);
> >
> > I would do it with a conditional
> >
> > if (osr ...)
> > return regmap_update_bits(st->regmap, AD4851_REG_PACKET,
> > AD4851_PACKET_FORMAT_MASK, 0);
> >
> > return regmap_update_bits(st->regmap, AD4851_REG_PACKET,
> > AD4851_PACKET_FORMAT_MASK, 1);
> >
> If we do this, regmap_set_bits() and regmap_clear_bits() would
> be even better.
Sure, but I want also to have the only one conditional, so the respective
helper functions can be easily read and followed.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-15 11:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 9:40 [PATCH v3 1/6] iio: backend: add API for interface get Antoniu Miclaus
2024-10-14 9:40 ` [PATCH v3 2/6] iio: backend: add support for data size set Antoniu Miclaus
2024-10-14 9:40 ` [PATCH v3 3/6] iio: adc: adi-axi-adc: add interface type Antoniu Miclaus
2024-10-14 11:42 ` Andy Shevchenko
2024-10-14 9:40 ` [PATCH v3 4/6] iio: adc: adi-axi-adc: set data format Antoniu Miclaus
2024-10-14 11:45 ` Andy Shevchenko
2024-10-14 9:40 ` [PATCH v3 5/6] dt-bindings: iio: adc: add ad4851 Antoniu Miclaus
2024-10-14 9:40 ` [PATCH v3 6/6] iio: adc: ad4851: add ad485x driver Antoniu Miclaus
2024-10-14 13:14 ` Andy Shevchenko
2024-10-14 19:15 ` Jonathan Cameron
2024-10-15 11:11 ` Andy Shevchenko
2024-10-15 16:08 ` David Lechner
2024-10-14 22:08 ` David Lechner
2024-10-15 11:13 ` Andy Shevchenko [this message]
2024-10-15 0:12 ` David Lechner
2024-10-25 11:35 ` Miclaus, Antoniu
2024-10-25 14:29 ` David Lechner
2024-10-25 19:55 ` David Lechner
2024-10-26 17:10 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw5OZAhzyhNUTPae@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alisadariana@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=dragos.bogdan@analog.com \
--cc=fr0st61te@gmail.com \
--cc=jic23@kernel.org \
--cc=joao.goncalves@toradex.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=marius.cristea@microchip.com \
--cc=mike.looijmans@topic.nl \
--cc=mitrutzceclan@gmail.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=robh@kernel.org \
--cc=sergiu.cuciurean@analog.com \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.