From: Keith Busch <kbusch@kernel.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Hannes Reinecke <hare@kernel.org>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/3] nvme-multipath: cannot disconnect controller on stuck partition scan
Date: Tue, 15 Oct 2024 09:10:28 -0600 [thread overview]
Message-ID: <Zw6F5LN6YuVVqFux@kbusch-mbp> (raw)
In-Reply-To: <4478f837-b504-44dd-8f5b-facab6aa8161@suse.de>
On Tue, Oct 15, 2024 at 04:56:08PM +0200, Hannes Reinecke wrote:
> On 10/15/24 16:33, Keith Busch wrote:
> > Is that actually happening for you? I don't think it's supposed to
> > happen because mpath_shutdwon_disk only happens if the head is detached
> > from the subsystem, so no other thread should be able to possibly
> > attempt to access that head's disk for a different controller path. That
> > new controller should have to allocate an entirely new head.
>
> Na, forget it. Not only doesn't it happen, but we need the
> 'test_and_set_bit()' at the start otherwise we can't abort I/O.
> So all's fine with your patch, and it even survives my testcase.
>
> (The first to do so even after several runs, I might add :-)
>
> Care to send an official patch?
Should be in your mailbox. Here's the link:
https://lore.kernel.org/linux-nvme/20241015143136.810779-1-kbusch@meta.com/T/#u
next prev parent reply other threads:[~2024-10-15 15:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 10:01 [PATCH 0/3] nvme-multipath: fix deadlock in device_add_disk() Hannes Reinecke
2024-10-07 10:01 ` [PATCH 1/3] nvme-multipath: simplify loop in nvme_update_ana_state() Hannes Reinecke
2024-10-07 15:46 ` Keith Busch
2024-10-08 6:39 ` Christoph Hellwig
2024-10-20 23:33 ` Sagi Grimberg
2024-10-07 10:01 ` [PATCH 2/3] nvme-multipath: cannot disconnect controller on stuck partition scan Hannes Reinecke
2024-10-07 18:19 ` Keith Busch
2024-10-08 6:43 ` Christoph Hellwig
2024-10-08 7:17 ` Hannes Reinecke
2024-10-08 20:41 ` Keith Busch
2024-10-09 6:23 ` Hannes Reinecke
2024-10-09 16:33 ` Keith Busch
2024-10-09 17:10 ` Keith Busch
2024-10-09 17:32 ` Keith Busch
2024-10-10 6:16 ` Hannes Reinecke
2024-10-10 7:18 ` Hannes Reinecke
2024-10-10 8:17 ` Christoph Hellwig
2024-10-10 8:57 ` Hannes Reinecke
2024-10-15 14:33 ` Keith Busch
2024-10-15 14:56 ` Hannes Reinecke
2024-10-15 15:10 ` Keith Busch [this message]
2024-10-20 23:37 ` Sagi Grimberg
2024-10-07 10:01 ` [PATCH 3/3] nvme-multipath: skip failed paths during " Hannes Reinecke
2024-10-08 6:40 ` Christoph Hellwig
2024-10-20 23:38 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw6F5LN6YuVVqFux@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hare@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.