Re: [PATCH] CI: Fix builds following qemu-xen update

[Anthony PERARD <anthony.perard@vates.tech>]

On Fri, Oct 04, 2024 at 06:27:23PM +0100, Andrew Cooper wrote:
> A recent update to qemu-xen has bumped the build requirements, with Python 3.8
> being the new baseline but also needing the 'ensurepip' and 'tomllib/tomli'
> packages.
> 
>  * Ubuntu/Debian package 'ensurepip' separately, but it can be obtained by
>    installing the python3-venv package.
> 
>  * 'tomllib' was added to the python standard library in Python 3.11, but
>    previously it was a separate package named 'tomli'.
> 
> In terms of changes required to build QEMU:
> 
>  * Ubuntu 24.04 (Noble) has Python 3.12 so only needs python3-venv
> 
>  * Ubuntu 22.04 (Jammy) has Python 3.10 but does have a python3-tomli package
>    that QEMU is happy with.
> 
>  * FreeBSD has Python 3.9, but Python 3.11 is available.
> 
> In terms of exclusions:
> 
>  * Ubuntu 20.04 (Focal) has Python 3.8, but lacks any kind of tomli package.
> 
>  * Fedora 29 (Python 3.7), OpenSUSE Leap 15.6 (Python 3.6), and Ubuntu
>    18.04/Bionic (Python 3.6) are now too old.
> 
> Detecting tomllib/tomli is more than can fit in build's oneliner, so break it
> out into a proper script.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

The changes on the gitlab side look fine. I don't know if the changes on
the cirrus side are ok, but at least the seems to work, after looking at
the build logs. So:

Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>

Thanks,

-- 

Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech