From: Jiri Olsa <olsajiri@gmail.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: KP Singh <kpsingh@kernel.org>,
Matt Bobrowski <mattbobrowski@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Casey Schaufler <casey@schaufler-ca.com>,
Paul Moore <paul@paul-moore.com>,
John Johansen <john.johansen@canonical.com>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bpf, lsm: Remove bpf_lsm_key_free hook
Date: Sat, 5 Oct 2024 15:45:23 +0200 [thread overview]
Message-ID: <ZwE_veRD7f2ir6mS@krava> (raw)
In-Reply-To: <20241005-lsm-key_free-v1-1-42ea801dbd63@weissschuh.net>
On Sat, Oct 05, 2024 at 02:06:28AM +0200, Thomas Weißschuh wrote:
> The key_free LSM hook has been removed.
> Remove the corresponding BPF hook.
>
> Avoid warnings during the build:
> BTFIDS vmlinux
> WARN: resolve_btfids: unresolved symbol bpf_lsm_key_free
nice, I was wondering about that, lgtm
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
>
> Fixes: 5f8d28f6d7d5 ("lsm: infrastructure management of the key security blob")
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> I don't know much about LSMs, so please disregard if this is wrong.
> ---
> kernel/bpf/bpf_lsm.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/kernel/bpf/bpf_lsm.c b/kernel/bpf/bpf_lsm.c
> index 6292ac5f9bd139dafb39ecd8bb180be46cd7c7fd..3bc61628ab251e05d7837eb27dabc3b62bcc4783 100644
> --- a/kernel/bpf/bpf_lsm.c
> +++ b/kernel/bpf/bpf_lsm.c
> @@ -339,10 +339,6 @@ BTF_ID(func, bpf_lsm_path_chmod)
> BTF_ID(func, bpf_lsm_path_chown)
> #endif /* CONFIG_SECURITY_PATH */
>
> -#ifdef CONFIG_KEYS
> -BTF_ID(func, bpf_lsm_key_free)
> -#endif /* CONFIG_KEYS */
> -
> BTF_ID(func, bpf_lsm_mmap_file)
> BTF_ID(func, bpf_lsm_netlink_send)
> BTF_ID(func, bpf_lsm_path_notify)
>
> ---
> base-commit: 0c559323bbaabee7346c12e74b497e283aaafef5
> change-id: 20241005-lsm-key_free-b47445ee523d
>
> Best regards,
> --
> Thomas Weißschuh <linux@weissschuh.net>
>
next prev parent reply other threads:[~2024-10-05 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 0:06 [PATCH] bpf, lsm: Remove bpf_lsm_key_free hook Thomas Weißschuh
2024-10-05 0:19 ` Song Liu
2024-10-05 13:45 ` Jiri Olsa [this message]
2024-10-08 3:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwE_veRD7f2ir6mS@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=casey@schaufler-ca.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=john.johansen@canonical.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=martin.lau@linux.dev \
--cc=mattbobrowski@google.com \
--cc=paul@paul-moore.com \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.