From: shejialuo <shejialuo@gmail.com>
To: Usman Akinyemi <usmanakinyemi202@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Usman Akinyemi via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH v2] [Outreachy][Patch v1] t3404: avoid losing exit status to pipes
Date: Sun, 6 Oct 2024 21:36:07 +0800 [thread overview]
Message-ID: <ZwKSR48mlSME9J0w@ArchLinux> (raw)
In-Reply-To: <CAPSxiM_+LCH04ZbTZm8oZWDc=Mz2JNJ_Uw7u+gO4e_ie4yPw5g@mail.gmail.com>
On Sun, Oct 06, 2024 at 01:27:00PM +0000, Usman Akinyemi wrote:
> Thanks very much Jialuo,
>
> My understanding of this, kindly tell me if I am wrong.
>
> 1. Make a new commit for test_line_count on the same branch right ?
> 2. I should remove the "Outreachy][Patch v1]" in the first patch to
> enhance the commit message right?
>
For 1, it is correct. For 2, if you decide to change the commit message
of the first patch, you should also follow the advice from Eric in [1].
> It probably would have been helpful to reviewers if the patch's
> commit message mentioned that it only converts some of the
> instances, but it's not worth rerolling the patch just for that.
[1] https://lore.kernel.org/git/CAPig+cRePbX6OyE6WhFp1GEZenZyC7HFeA3188F_nErt7Gin6A@mail.gmail.com/
next prev parent reply other threads:[~2024-10-06 13:36 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-06 5:33 [PATCH 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes Usman Akinyemi via GitGitGadget
2024-10-06 5:33 ` [PATCH 1/2] [Outreachy][Patch v1] " Usman Akinyemi via GitGitGadget
2024-10-06 5:55 ` Eric Sunshine
2024-10-06 6:31 ` Usman Akinyemi
2024-10-06 5:33 ` [PATCH 2/2] [Outreachy][Patch v2] " Usman Akinyemi via GitGitGadget
2024-10-06 5:48 ` Eric Sunshine
2024-10-06 6:30 ` Usman Akinyemi
2024-10-06 7:28 ` Eric Sunshine
2024-10-06 8:26 ` Usman Akinyemi
2024-10-06 8:31 ` [PATCH v2] [Outreachy][Patch v1] " Usman Akinyemi via GitGitGadget
2024-10-06 9:19 ` Eric Sunshine
2024-10-06 9:32 ` Usman Akinyemi
2024-10-06 10:21 ` Eric Sunshine
2024-10-06 11:12 ` shejialuo
2024-10-06 12:06 ` Eric Sunshine
2024-10-06 12:28 ` Usman Akinyemi
2024-10-06 13:03 ` shejialuo
2024-10-06 13:27 ` Usman Akinyemi
2024-10-06 13:36 ` shejialuo [this message]
2024-10-06 12:29 ` shejialuo
2024-10-06 12:46 ` Usman Akinyemi
2024-10-07 4:19 ` Eric Sunshine
2024-10-06 16:06 ` [PATCH v3 0/2] [Outreachy][Patch v2] " Usman Akinyemi via GitGitGadget
2024-10-06 16:06 ` [PATCH v3 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-files` Usman Akinyemi via GitGitGadget
2024-10-07 6:04 ` Patrick Steinhardt
2024-10-07 8:52 ` phillip.wood123
2024-10-07 9:05 ` Usman Akinyemi
2024-10-06 16:06 ` [PATCH v3 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test Usman Akinyemi via GitGitGadget
2024-10-06 16:31 ` Kristoffer Haugsbakk
2024-10-07 4:38 ` Eric Sunshine
2024-10-07 6:05 ` Patrick Steinhardt
2024-10-07 7:32 ` Usman Akinyemi
2024-10-07 9:00 ` phillip.wood123
2024-10-06 16:18 ` [PATCH v3 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes Usman Akinyemi
2024-10-07 4:24 ` Eric Sunshine
2024-10-07 7:25 ` Usman Akinyemi
2024-10-07 8:08 ` Patrick Steinhardt
2024-10-07 8:11 ` Eric Sunshine
2024-10-07 9:01 ` Usman Akinyemi
2024-10-06 16:21 ` Kristoffer Haugsbakk
2024-10-06 16:26 ` Usman Akinyemi
2024-10-07 5:55 ` Patrick Steinhardt
2024-10-07 10:22 ` [PATCH v4 " Usman Akinyemi via GitGitGadget
2024-10-07 10:22 ` [PATCH v4 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` Usman Akinyemi via GitGitGadget
2024-10-07 10:22 ` [PATCH v4 2/2] [Outreachy][Patch v1] t3404: employing test_line_count() to replace test Usman Akinyemi via GitGitGadget
2024-10-07 10:28 ` Patrick Steinhardt
2024-10-07 10:51 ` [PATCH v5 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes Usman Akinyemi via GitGitGadget
2024-10-07 10:51 ` [PATCH v5 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` Usman Akinyemi via GitGitGadget
2024-10-07 10:51 ` [PATCH v5 2/2] t3404: employing test_line_count() to replace test Usman Akinyemi via GitGitGadget
2024-10-07 10:54 ` Patrick Steinhardt
2024-10-07 11:10 ` Usman Akinyemi
2024-10-07 11:11 ` [PATCH v6 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes Usman Akinyemi via GitGitGadget
2024-10-07 11:11 ` [PATCH v6 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` Usman Akinyemi via GitGitGadget
2024-10-07 11:11 ` [PATCH v6 2/2] t3404: employing test_line_count() to replace test Usman Akinyemi via GitGitGadget
2024-10-07 15:07 ` Phillip Wood
2024-10-07 15:32 ` Usman Akinyemi
2024-10-07 11:12 ` [PATCH v6 0/2] [Outreachy][Patch v2] t3404: avoid losing exit status to pipes Patrick Steinhardt
2024-10-07 11:16 ` Usman Akinyemi
2024-10-07 11:32 ` Patrick Steinhardt
2024-10-07 11:44 ` Usman Akinyemi
2024-10-07 15:32 ` [PATCH v7 " Usman Akinyemi via GitGitGadget
2024-10-07 15:32 ` [PATCH v7 1/2] t3404: avoid losing exit status with focus on `git show` and `git cat-file` Usman Akinyemi via GitGitGadget
2024-10-07 15:32 ` [PATCH v7 2/2] t3404: replace test with test_line_count() Usman Akinyemi via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwKSR48mlSME9J0w@ArchLinux \
--to=shejialuo@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.