From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, manos.pitsidianakis@linaro.org,
zhao1.liu@intel.com, junjie.mao@intel.com,
pierrick.bouvier@linaro.org, alex.bennee@linaro.org
Subject: Re: [PULL 00/12] Rust initial PoC + meson changes for 2024-10-07
Date: Mon, 7 Oct 2024 12:11:49 +0100 [thread overview]
Message-ID: <ZwPB9SnTvkr082NA@redhat.com> (raw)
In-Reply-To: <20241007110342.1298598-1-pbonzini@redhat.com>
On Mon, Oct 07, 2024 at 01:03:28PM +0200, Paolo Bonzini wrote:
> The following changes since commit b5ab62b3c0050612c7f9b0b4baeb44ebab42775a:
>
> Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2024-10-04 19:28:37 +0100)
>
> are available in the Git repository at:
>
> https://gitlab.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to dec4b629fc17fedcd2172066071f99ec8dcc8d8d:
>
> meson: ensure -mcx16 is passed when detecting ATOMIC128 (2024-10-07 13:01:06 +0200)
>
> ----------------------------------------------------------------
> * first commit for Rust support
> * fix detection of ATOMIC128 on x86_64
>
> ----------------------------------------------------------------
> Manos Pitsidianakis (7):
> build-sys: Add rust feature option
> rust: add bindgen step as a meson dependency
> .gitattributes: add Rust diff and merge attributes
> meson.build: add HAVE_GLIB_WITH_ALIGNED_ALLOC flag
> rust: add crate to expose bindings and interfaces
> rust: add utility procedural macro crate
> rust: add PL011 device model
>
> Paolo Bonzini (4):
> Require meson version 1.5.0
> configure, meson: detect Rust toolchain
> meson: define qemu_isa_flags
> meson: ensure -mcx16 is passed when detecting ATOMIC128
>
> Pierrick Bouvier (1):
> meson: fix machine option for x86_version
The current dockerfiles don't include rust, and I see nothing
here updating them to add rust, so how is any of this getting
test coverage ?
Even though this has Rust disabled by default, I would still
consider CI enablement to be a pre-requsite for merging even
basic Rust support.
>
> MAINTAINERS | 21 +
> configure | 170 +++++-
> meson.build | 158 +++++-
> rust/wrapper.h | 47 ++
> .gitattributes | 3 +
> Kconfig | 1 +
> Kconfig.host | 3 +
> hw/arm/Kconfig | 30 +-
> meson_options.txt | 3 +
> python/scripts/vendor.py | 4 +-
> python/wheels/meson-1.2.3-py3-none-any.whl | Bin 964928 -> 0 bytes
> python/wheels/meson-1.5.0-py3-none-any.whl | Bin 0 -> 959846 bytes
> pythondeps.toml | 2 +-
> rust/.gitignore | 3 +
> rust/Kconfig | 1 +
> rust/hw/Kconfig | 2 +
> rust/hw/char/Kconfig | 3 +
> rust/hw/char/meson.build | 1 +
> rust/hw/char/pl011/.gitignore | 2 +
> rust/hw/char/pl011/Cargo.lock | 134 +++++
> rust/hw/char/pl011/Cargo.toml | 26 +
> rust/hw/char/pl011/README.md | 31 ++
> rust/hw/char/pl011/meson.build | 26 +
> rust/hw/char/pl011/src/device.rs | 599 +++++++++++++++++++++
> rust/hw/char/pl011/src/device_class.rs | 70 +++
> rust/hw/char/pl011/src/lib.rs | 586 ++++++++++++++++++++
> rust/hw/char/pl011/src/memory_ops.rs | 59 ++
> rust/hw/meson.build | 1 +
> rust/meson.build | 4 +
> rust/qemu-api-macros/Cargo.lock | 47 ++
> rust/qemu-api-macros/Cargo.toml | 25 +
> rust/qemu-api-macros/README.md | 1 +
> rust/qemu-api-macros/meson.build | 25 +
> rust/qemu-api-macros/src/lib.rs | 43 ++
> rust/qemu-api/.gitignore | 2 +
> rust/qemu-api/Cargo.lock | 7 +
> rust/qemu-api/Cargo.toml | 26 +
> rust/qemu-api/README.md | 17 +
> rust/qemu-api/build.rs | 14 +
> rust/qemu-api/meson.build | 24 +
> rust/qemu-api/src/definitions.rs | 97 ++++
> rust/qemu-api/src/device_class.rs | 128 +++++
> rust/qemu-api/src/lib.rs | 166 ++++++
> rust/qemu-api/src/tests.rs | 49 ++
> rust/rustfmt.toml | 7 +
> scripts/archive-source.sh | 6 +-
> scripts/make-release | 5 +-
> scripts/meson-buildoptions.sh | 3 +
> scripts/rust/rust_root_crate.sh | 13 +
> scripts/rust/rustc_args.py | 84 +++
> subprojects/.gitignore | 11 +
> subprojects/arbitrary-int-1-rs.wrap | 7 +
> subprojects/bilge-0.2-rs.wrap | 7 +
> subprojects/bilge-impl-0.2-rs.wrap | 7 +
> subprojects/either-1-rs.wrap | 7 +
> subprojects/itertools-0.11-rs.wrap | 7 +
> .../packagefiles/arbitrary-int-1-rs/meson.build | 19 +
> subprojects/packagefiles/bilge-0.2-rs/meson.build | 29 +
> .../packagefiles/bilge-impl-0.2-rs/meson.build | 45 ++
> subprojects/packagefiles/either-1-rs/meson.build | 24 +
> .../packagefiles/itertools-0.11-rs/meson.build | 30 ++
> .../packagefiles/proc-macro-error-1-rs/meson.build | 40 ++
> .../proc-macro-error-attr-1-rs/meson.build | 32 ++
> .../packagefiles/proc-macro2-1-rs/meson.build | 31 ++
> subprojects/packagefiles/quote-1-rs/meson.build | 29 +
> subprojects/packagefiles/syn-2-rs/meson.build | 40 ++
> .../packagefiles/unicode-ident-1-rs/meson.build | 20 +
> subprojects/proc-macro-error-1-rs.wrap | 7 +
> subprojects/proc-macro-error-attr-1-rs.wrap | 7 +
> subprojects/proc-macro2-1-rs.wrap | 7 +
> subprojects/quote-1-rs.wrap | 7 +
> subprojects/syn-2-rs.wrap | 7 +
> subprojects/unicode-ident-1-rs.wrap | 7 +
> subprojects/unicode-ident-1-rs/meson.build | 20 +
> tests/lcitool/mappings.yml | 2 +-
> 75 files changed, 3194 insertions(+), 34 deletions(-)
> create mode 100644 rust/wrapper.h
> delete mode 100644 python/wheels/meson-1.2.3-py3-none-any.whl
> create mode 100644 python/wheels/meson-1.5.0-py3-none-any.whl
> create mode 100644 rust/.gitignore
> create mode 100644 rust/Kconfig
> create mode 100644 rust/hw/Kconfig
> create mode 100644 rust/hw/char/Kconfig
> create mode 100644 rust/hw/char/meson.build
> create mode 100644 rust/hw/char/pl011/.gitignore
> create mode 100644 rust/hw/char/pl011/Cargo.lock
> create mode 100644 rust/hw/char/pl011/Cargo.toml
> create mode 100644 rust/hw/char/pl011/README.md
> create mode 100644 rust/hw/char/pl011/meson.build
> create mode 100644 rust/hw/char/pl011/src/device.rs
> create mode 100644 rust/hw/char/pl011/src/device_class.rs
> create mode 100644 rust/hw/char/pl011/src/lib.rs
> create mode 100644 rust/hw/char/pl011/src/memory_ops.rs
> create mode 100644 rust/hw/meson.build
> create mode 100644 rust/meson.build
> create mode 100644 rust/qemu-api-macros/Cargo.lock
> create mode 100644 rust/qemu-api-macros/Cargo.toml
> create mode 100644 rust/qemu-api-macros/README.md
> create mode 100644 rust/qemu-api-macros/meson.build
> create mode 100644 rust/qemu-api-macros/src/lib.rs
> create mode 100644 rust/qemu-api/.gitignore
> create mode 100644 rust/qemu-api/Cargo.lock
> create mode 100644 rust/qemu-api/Cargo.toml
> create mode 100644 rust/qemu-api/README.md
> create mode 100644 rust/qemu-api/build.rs
> create mode 100644 rust/qemu-api/meson.build
> create mode 100644 rust/qemu-api/src/definitions.rs
> create mode 100644 rust/qemu-api/src/device_class.rs
> create mode 100644 rust/qemu-api/src/lib.rs
> create mode 100644 rust/qemu-api/src/tests.rs
> create mode 100644 rust/rustfmt.toml
> create mode 100755 scripts/rust/rust_root_crate.sh
> create mode 100644 scripts/rust/rustc_args.py
> create mode 100644 subprojects/arbitrary-int-1-rs.wrap
> create mode 100644 subprojects/bilge-0.2-rs.wrap
> create mode 100644 subprojects/bilge-impl-0.2-rs.wrap
> create mode 100644 subprojects/either-1-rs.wrap
> create mode 100644 subprojects/itertools-0.11-rs.wrap
> create mode 100644 subprojects/packagefiles/arbitrary-int-1-rs/meson.build
> create mode 100644 subprojects/packagefiles/bilge-0.2-rs/meson.build
> create mode 100644 subprojects/packagefiles/bilge-impl-0.2-rs/meson.build
> create mode 100644 subprojects/packagefiles/either-1-rs/meson.build
> create mode 100644 subprojects/packagefiles/itertools-0.11-rs/meson.build
> create mode 100644 subprojects/packagefiles/proc-macro-error-1-rs/meson.build
> create mode 100644 subprojects/packagefiles/proc-macro-error-attr-1-rs/meson.build
> create mode 100644 subprojects/packagefiles/proc-macro2-1-rs/meson.build
> create mode 100644 subprojects/packagefiles/quote-1-rs/meson.build
> create mode 100644 subprojects/packagefiles/syn-2-rs/meson.build
> create mode 100644 subprojects/packagefiles/unicode-ident-1-rs/meson.build
> create mode 100644 subprojects/proc-macro-error-1-rs.wrap
> create mode 100644 subprojects/proc-macro-error-attr-1-rs.wrap
> create mode 100644 subprojects/proc-macro2-1-rs.wrap
> create mode 100644 subprojects/quote-1-rs.wrap
> create mode 100644 subprojects/syn-2-rs.wrap
> create mode 100644 subprojects/unicode-ident-1-rs.wrap
> create mode 100644 subprojects/unicode-ident-1-rs/meson.build
> --
> 2.46.1
>
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-10-07 11:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 11:03 [PULL 00/12] Rust initial PoC + meson changes for 2024-10-07 Paolo Bonzini
2024-10-07 11:03 ` [PULL 01/12] Require meson version 1.5.0 Paolo Bonzini
2024-10-07 11:03 ` [PULL 02/12] build-sys: Add rust feature option Paolo Bonzini
2024-10-07 11:03 ` [PULL 03/12] configure, meson: detect Rust toolchain Paolo Bonzini
2024-10-07 11:03 ` [PULL 04/12] rust: add bindgen step as a meson dependency Paolo Bonzini
2024-10-07 11:03 ` [PULL 05/12] .gitattributes: add Rust diff and merge attributes Paolo Bonzini
2024-10-07 11:03 ` [PULL 06/12] meson.build: add HAVE_GLIB_WITH_ALIGNED_ALLOC flag Paolo Bonzini
2024-10-07 11:03 ` [PULL 07/12] rust: add crate to expose bindings and interfaces Paolo Bonzini
2024-10-07 11:03 ` [PULL 08/12] rust: add utility procedural macro crate Paolo Bonzini
2024-10-07 11:03 ` [PULL 09/12] rust: add PL011 device model Paolo Bonzini
2024-10-07 11:03 ` [PULL 10/12] meson: fix machine option for x86_version Paolo Bonzini
2024-10-07 11:03 ` [PULL 11/12] meson: define qemu_isa_flags Paolo Bonzini
2024-10-07 11:03 ` [PULL 12/12] meson: ensure -mcx16 is passed when detecting ATOMIC128 Paolo Bonzini
2024-10-07 11:11 ` Daniel P. Berrangé [this message]
2024-10-07 11:26 ` [PULL 00/12] Rust initial PoC + meson changes for 2024-10-07 Paolo Bonzini
2024-10-07 11:47 ` Daniel P. Berrangé
2024-10-07 11:52 ` Daniel P. Berrangé
2024-10-07 15:51 ` Paolo Bonzini
2024-10-07 17:56 ` Brian Cain
2024-10-07 19:15 ` Paolo Bonzini
2024-10-08 3:27 ` Brian Cain
2024-10-08 3:39 ` Pierrick Bouvier
2024-10-08 10:01 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwPB9SnTvkr082NA@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=junjie.mao@intel.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.