From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: <bpf@vger.kernel.org>, <ast@kernel.org>, <andrii@kernel.org>,
<netdev@vger.kernel.org>, <magnus.karlsson@intel.com>,
<bjorn@kernel.org>
Subject: Re: [PATCH bpf-next 1/6] xsk: get rid of xdp_buff_xsk::xskb_list_node
Date: Mon, 7 Oct 2024 14:16:14 +0200 [thread overview]
Message-ID: <ZwPRDgPKss2s/CvB@boxer> (raw)
In-Reply-To: <51371534-5813-480f-b797-f073c31df5de@iogearbox.net>
On Fri, Oct 04, 2024 at 02:08:38PM +0200, Daniel Borkmann wrote:
> On 10/2/24 5:54 PM, Maciej Fijalkowski wrote:
> > Let's bring xdp_buff_xsk back to occupying 2 cachelines by removing
> > xskb_list_node - for the purpose of gathering the xskb frags
> > free_list_node can be used, head of the list (xsk_buff_pool::xskb_list)
> > stays as-is, just reuse the node ptr.
> >
> > It is safe to do as a single xdp_buff_xsk can never reside in two
> > pool's lists simultaneously.
> >
> > Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
>
> Given you send v2 anyway, pls also double check the clang errors from netdev CI:
> https://netdev.bots.linux.dev/static/nipa/894909/13820003/build_clang/summary
Thanks, fixed in v2.
next prev parent reply other threads:[~2024-10-07 12:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 15:54 [PATCH bpf-next 0/6] xsk: struct diet and cleanups Maciej Fijalkowski
2024-10-02 15:54 ` [PATCH bpf-next 1/6] xsk: get rid of xdp_buff_xsk::xskb_list_node Maciej Fijalkowski
2024-10-04 12:08 ` Daniel Borkmann
2024-10-07 12:16 ` Maciej Fijalkowski [this message]
2024-10-02 15:54 ` [PATCH bpf-next 2/6] xsk: s/free_list_node/list_node Maciej Fijalkowski
2024-10-02 15:54 ` [PATCH bpf-next 3/6] xsk: get rid of xdp_buff_xsk::orig_addr Maciej Fijalkowski
2024-10-02 15:54 ` [PATCH bpf-next 4/6] xsk: carry a copy of xdp_zc_max_segs within xsk_buff_pool Maciej Fijalkowski
2024-10-02 19:41 ` Vadim Fedorenko
2024-10-03 11:47 ` Maciej Fijalkowski
2024-10-02 15:54 ` [PATCH bpf-next 5/6] xsk: wrap duplicated code to function Maciej Fijalkowski
2024-10-02 15:54 ` [PATCH bpf-next 6/6] xsk: use xsk_buff_pool directly for cq functions Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwPRDgPKss2s/CvB@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.