Re: [PATCH] firmware: arm_scmi: Queue in scmi layer for mailbox implementation

[Cristian Marussi <cristian.marussi@arm.com>]

On Mon, Oct 07, 2024 at 02:04:10PM +0100, Sudeep Holla wrote:
> On Fri, Oct 04, 2024 at 03:12:57PM -0700, Justin Chen wrote:
> > The mailbox layer has its own queue. However this confuses the per
> > message timeouts since the clock starts ticking the moment the messages
> > get queued up. So all messages in the queue have there timeout clocks
> > ticking instead of only the message inflight. To fix this, lets move the
> > queue back into the SCMI layer.
> >
> 
> I think this has come up in the past. We have avoided adding addition
> locking here as the mailbox layer takes care of it. Has anything changed
> recently ?

I asked for an explanation in my reply (we crossed each other mails probably)
since it alredy came up in the past a few times and central locking seemed not
to be needed...here the difference is about the reason...Justin talks about
message timeouts related to the queueing process..so I asked to better
explain the detail (and the anbomaly observed) since it still does not
seem to me that even in this case the lock is needed....anyway I can
definitely be woring of course :D

Thanks,
Cristian