From: Peter Xu <peterx@redhat.com>
To: manas18244@iiitd.ac.in
Cc: Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Anup Sharma <anupnewsmail@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
syzbot+093d096417e7038a689b@syzkaller.appspotmail.com
Subject: Re: [PATCH v4] Fixes: null pointer dereference in pfnmap_lockdep_assert
Date: Mon, 7 Oct 2024 09:25:00 -0400 [thread overview]
Message-ID: <ZwPhLFIk4gvhn10d@x1n> (raw)
In-Reply-To: <20241004-fix-null-deref-v4-1-d0a8ec01ac85@iiitd.ac.in>
On Fri, Oct 04, 2024 at 11:12:16PM +0530, Manas via B4 Relay wrote:
> From: Manas <manas18244@iiitd.ac.in>
>
> syzbot has pointed to a possible null pointer dereference in
> pfnmap_lockdep_assert. vm_file member of vm_area_struct is being
> dereferenced without any checks.
>
> This fix assigns mapping only if vm_file is not NULL.
>
> Reported-by: syzbot+093d096417e7038a689b@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=093d096417e7038a689b
> ---
> This bug[1] triggers a general protection fault in follow_pfnmap_start
> function. An assertion pfnmap_lockdep_assert inside this function
> dereferences vm_file member of vm_area_struct. And panic gets triggered
> when vm_file is NULL.
>
> This patch assigns mapping only if vm_file is not NULL.
>
> [1] https://syzkaller.appspot.com/bug?extid=093d096417e7038a689b
>
> Signed-off-by: Manas <manas18244@iiitd.ac.in>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
prev parent reply other threads:[~2024-12-05 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 17:42 [PATCH v4] Fixes: null pointer dereference in pfnmap_lockdep_assert Manas
2024-10-04 17:42 ` Manas via B4 Relay
2024-10-07 13:25 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwPhLFIk4gvhn10d@x1n \
--to=peterx@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anupnewsmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=manas18244@iiitd.ac.in \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+093d096417e7038a689b@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.