From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06827CFB44F for ; Mon, 7 Oct 2024 16:50:11 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sxqvv-0004Vl-Ox; Mon, 07 Oct 2024 16:50:08 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sxqvu-0004Vf-Hh for linux-f2fs-devel@lists.sourceforge.net; Mon, 07 Oct 2024 16:50:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tB1bpNUrJogyAqtBapESn5o6BSN7Fgu1X6AOjaCglv0=; b=CzWGecx7687Z7ZTu8z1iFfD92l bwFzp7UfVF7maEPmY9LiYG27HPGF3pUa/8KUncx+09HNuyfAClKDsAQA9UcojVmFuZGlx/rhlDva6 1jJO3mHaNr5DchVhuXwEPBLiTBJ3p/Mb8eDQzi74InW4VAeNoc0sZru8CyrO9MQdpqzQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tB1bpNUrJogyAqtBapESn5o6BSN7Fgu1X6AOjaCglv0=; b=CKBvk5YHvVHE7X6aRqx0m4TVli P4I1e6xn+7ZKcb87kvYAFlXX6vNjl8l+iq3QZTNfF/TTD2DghoI3FdEs6lQcesrE6ZKv+orNdUr25 idsJpMc+tzwvwhsJAaQzIc7yZMssPr4JTbV3BnwG1hdzTL69Ckfmyand+LgXj+adQ/Dk=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1sxqvu-0000Ns-Ez for linux-f2fs-devel@lists.sourceforge.net; Mon, 07 Oct 2024 16:50:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D0D425C24D5; Mon, 7 Oct 2024 16:49:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66BB0C4CEC6; Mon, 7 Oct 2024 16:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728319795; bh=QSEWGceGF+zqW4Mxm7quS90OIzr3oPTDd3vjuevYd9A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PxidwWF5tOsu57/gIOobA09HS9QboVYxvrlD7pq23ZIbz7SUm4c3GAlgi/yljMb8O HzJf37CDNJZIUKSBVuN0fc4Y+TyClDXdb1baExy4dU9lrMSV8sZ+09s7SB80MFKS6J woWjs9wBvCB9aHDQ16wtZpSYc+KqvlzXkwEBJxbqWQCVJSnUrZwHp0IiT5lfCyLwcT iekqIhB+8BAvz5tyU/qfsq4df43HoMVo2EWJ2gSRiu6D2KfXqu1GXFNqCJ1fmn2LC4 zdrGv3fG0K6jK3Rfa59/Gp1eBTew0bnsIzmW40L3GadWjrQAsk2IIC5G7MVahPHvON OekUjVUbduvgQ== Date: Mon, 7 Oct 2024 16:49:53 +0000 To: Zhiguo Niu Message-ID: References: <1726283507-16611-1-git-send-email-zhiguo.niu@unisoc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1sxqvu-0000Ns-Ez Subject: Re: [f2fs-dev] [PATCH] f2fs-toos: use getpagesize() to get default blocksize in Android X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jaegeuk Kim via Linux-f2fs-devel Reply-To: Jaegeuk Kim Cc: xiuhong.wang@unisoc.com, Zhiguo Niu , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMDkvMTksIFpoaWd1byBOaXUgd3JvdGU6Cj4gSGkgYWxsLAo+IHBsZWFzZSBpZ25vcmUgdGhp cyBwYXRjaCwgIHdlIGNhbiByZXNvdmUgdGhpcyBieSAiLWIiIHBhcmFtZXRlciAuCj4gdGhhbmtz IQoKT2ssIHRoYW5rcy4KCj4gWmhpZ3VvIE5pdSA8emhpZ3VvLm5pdUB1bmlzb2MuY29tPiDkuo4y MDI05bm0OeaciDE05pel5ZGo5YWtIDExOjEy5YaZ6YGT77yaCj4gPgo+ID4gV2hlbiAxNksgcGFn ZS9ibG9jayBzaXplIGlzIGVuYWJsZWQgaW4gQW5kcm9pZCBwbGF0Zm9ybSwKPiA+IGEgZXJyb3Ig bWF5YmUgZGV0ZWN0ZWQgaW4gbW91bnQgcHJvY2VzcyBpbiBrZXJuZWwgaWYgIi1iIgo+ID4gcGFy YW1ldGVycyBpcyBub3Qgc3BlY2lmaWVkIGluIG1rZnMuZjJmcy4KPiA+IEp1c3QgYXMgdGhlIGZv bGxvd2luZyBjaGVjazoKPiA+IGlmIChsZTMyX3RvX2NwdShyYXdfc3VwZXItPmxvZ19ibG9ja3Np emUpICE9IEYyRlNfQkxLU0laRV9CSVRTKQo+ID4KPiA+IFNvIHVzZSBnZXRwYWdlc2l6ZSgpIHRv IGdldCBjb3JyZWN0IGRlZmF1bHQgYmxvY2tzaXplLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IFpo aWd1byBOaXUgPHpoaWd1by5uaXVAdW5pc29jLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IFhpdWhv bmcgV2FuZyA8eGl1aG9uZy53YW5nQHVuaXNvYy5jb20+Cj4gPiAtLS0KPiA+ICBsaWIvbGliZjJm cy5jIHwgOSArKysrKysrKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspCj4g Pgo+ID4gZGlmZiAtLWdpdCBhL2xpYi9saWJmMmZzLmMgYi9saWIvbGliZjJmcy5jCj4gPiBpbmRl eCBlY2QyMmQ0Li45OGVlMGFlIDEwMDY0NAo+ID4gLS0tIGEvbGliL2xpYmYyZnMuYwo+ID4gKysr IGIvbGliL2xpYmYyZnMuYwo+ID4gQEAgLTY4NSw4ICs2ODUsMTcgQEAgdm9pZCBmMmZzX2luaXRf Y29uZmlndXJhdGlvbih2b2lkKQo+ID4KPiA+ICAgICAgICAgbWVtc2V0KCZjLCAwLCBzaXplb2Yo c3RydWN0IGYyZnNfY29uZmlndXJhdGlvbikpOwo+ID4gICAgICAgICBjLm5kZXZzID0gMTsKPiA+ ICsjaWZkZWYgV0lUSF9BTkRST0lECj4gPiArICAgICAgIGMuYmxrc2l6ZSA9IGdldHBhZ2VzaXpl KCk7Cj4gPiArICAgICAgIGMuYmxrc2l6ZV9iaXRzID0gbG9nX2Jhc2VfMihjLmJsa3NpemUpOwo+ ID4gKyAgICAgICBpZiAoKDEgPDwgYy5ibGtzaXplX2JpdHMpICE9IGMuYmxrc2l6ZSkgewo+ID4g KyAgICAgICAgICAgICAgIGMuYmxrc2l6ZSA9IDEgPDwgREVGQVVMVF9CTEtTSVpFX0JJVFM7Cj4g PiArICAgICAgICAgICAgICAgYy5ibGtzaXplX2JpdHMgPSBERUZBVUxUX0JMS1NJWkVfQklUUzsK PiA+ICsgICAgICAgfQo+ID4gKyNlbHNlCj4gPiAgICAgICAgIGMuYmxrc2l6ZSA9IDEgPDwgREVG QVVMVF9CTEtTSVpFX0JJVFM7Cj4gPiAgICAgICAgIGMuYmxrc2l6ZV9iaXRzID0gREVGQVVMVF9C TEtTSVpFX0JJVFM7Cj4gPiArI2VuZGlmCj4gPiAgICAgICAgIGMuc2VjdG9yc19wZXJfYmxrID0g REVGQVVMVF9TRUNUT1JTX1BFUl9CTE9DSzsKPiA+ICAgICAgICAgYy5ibGtzX3Blcl9zZWcgPSBE RUZBVUxUX0JMT0NLU19QRVJfU0VHTUVOVDsKPiA+ICAgICAgICAgYy53YW50ZWRfdG90YWxfc2Vj dG9ycyA9IC0xOwo+ID4gLS0KPiA+IDEuOS4xCj4gPgoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0Ckxp bnV4LWYyZnMtZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNl Zm9yZ2UubmV0L2xpc3RzL2xpc3RpbmZvL2xpbnV4LWYyZnMtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F39FD1DC051 for ; Mon, 7 Oct 2024 16:49:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728319796; cv=none; b=BC/qMypmLF5HYwCP776XTMZROAV0k5SeWX8Tc9mEwQgWpPsoOqrxUH8fc2vhzXPXUH66j0lAF7F9Dqqs6SmzEMdeETWob68xI5UwBFnrTnIu5ZPf5/q5oGShqdUlDJf2phfUmbrUrQ5sxgSw7sZpRZP/tOerm9V9EcLRmo63vXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728319796; c=relaxed/simple; bh=QSEWGceGF+zqW4Mxm7quS90OIzr3oPTDd3vjuevYd9A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PEmSgY7QNxX+IP/5smb8O91rrj61yYr6SXmDQ4A61F6R335HtJRlhJDvSJSQkfBZ8EMqHrRFsUMgWAyPsojkuIc5vJvE8X9boLnHKkfB+91LZIT9HO/wIUkj9hB6DxOBoViHfKDC3jFFHXQu/fGSldI3LQjsKzCYkshk2rlo2TI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PxidwWF5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PxidwWF5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66BB0C4CEC6; Mon, 7 Oct 2024 16:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728319795; bh=QSEWGceGF+zqW4Mxm7quS90OIzr3oPTDd3vjuevYd9A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PxidwWF5tOsu57/gIOobA09HS9QboVYxvrlD7pq23ZIbz7SUm4c3GAlgi/yljMb8O HzJf37CDNJZIUKSBVuN0fc4Y+TyClDXdb1baExy4dU9lrMSV8sZ+09s7SB80MFKS6J woWjs9wBvCB9aHDQ16wtZpSYc+KqvlzXkwEBJxbqWQCVJSnUrZwHp0IiT5lfCyLwcT iekqIhB+8BAvz5tyU/qfsq4df43HoMVo2EWJ2gSRiu6D2KfXqu1GXFNqCJ1fmn2LC4 zdrGv3fG0K6jK3Rfa59/Gp1eBTew0bnsIzmW40L3GadWjrQAsk2IIC5G7MVahPHvON OekUjVUbduvgQ== Date: Mon, 7 Oct 2024 16:49:53 +0000 From: Jaegeuk Kim To: Zhiguo Niu Cc: Zhiguo Niu , chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, xiuhong.wang@unisoc.com Subject: Re: [PATCH] f2fs-toos: use getpagesize() to get default blocksize in Android Message-ID: References: <1726283507-16611-1-git-send-email-zhiguo.niu@unisoc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 09/19, Zhiguo Niu wrote: > Hi all, > please ignore this patch, we can resove this by "-b" parameter . > thanks! Ok, thanks. > Zhiguo Niu 于2024年9月14日周六 11:12写道： > > > > When 16K page/block size is enabled in Android platform, > > a error maybe detected in mount process in kernel if "-b" > > parameters is not specified in mkfs.f2fs. > > Just as the following check: > > if (le32_to_cpu(raw_super->log_blocksize) != F2FS_BLKSIZE_BITS) > > > > So use getpagesize() to get correct default blocksize. > > > > Signed-off-by: Zhiguo Niu > > Signed-off-by: Xiuhong Wang > > --- > > lib/libf2fs.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/lib/libf2fs.c b/lib/libf2fs.c > > index ecd22d4..98ee0ae 100644 > > --- a/lib/libf2fs.c > > +++ b/lib/libf2fs.c > > @@ -685,8 +685,17 @@ void f2fs_init_configuration(void) > > > > memset(&c, 0, sizeof(struct f2fs_configuration)); > > c.ndevs = 1; > > +#ifdef WITH_ANDROID > > + c.blksize = getpagesize(); > > + c.blksize_bits = log_base_2(c.blksize); > > + if ((1 << c.blksize_bits) != c.blksize) { > > + c.blksize = 1 << DEFAULT_BLKSIZE_BITS; > > + c.blksize_bits = DEFAULT_BLKSIZE_BITS; > > + } > > +#else > > c.blksize = 1 << DEFAULT_BLKSIZE_BITS; > > c.blksize_bits = DEFAULT_BLKSIZE_BITS; > > +#endif > > c.sectors_per_blk = DEFAULT_SECTORS_PER_BLOCK; > > c.blks_per_seg = DEFAULT_BLOCKS_PER_SEGMENT; > > c.wanted_total_sectors = -1; > > -- > > 1.9.1 > >