All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: SurajSonawane2415 <surajsonawane0215@gmail.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH v3] block: Fix uninitialized symbol 'bio' in blk_rq_prep_clone
Date: Tue, 8 Oct 2024 05:06:19 -0700	[thread overview]
Message-ID: <ZwUgO-ASFxcSa1b6@infradead.org> (raw)
In-Reply-To: <20241008120413.16402-1-surajsonawane0215@gmail.com>

> +		struct bio *bio = bio_alloc_clone(rq->q->disk->part0, bio_src, gfp_mask,
>  				      bs);

Overly long line here, plus now pretty weird positioning of the bs
argument.

Should be something like:

		struct bio *bio = bio_alloc_clone(rq->q->disk->part0, bio_src,
				gfp_mask, bs);


  reply	other threads:[~2024-10-08 12:06 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04 10:08 [PATCH] block: Fix uninitialized symbol 'bio' in blk_rq_prep_clone SurajSonawane2415
2024-10-04 12:22 ` Christoph Hellwig
2024-10-04 14:10   ` Explanation on Uninitialized Variable bio " SurajSonawane2415
2024-10-04 14:15     ` Hannes Reinecke
2024-10-04 14:33     ` John Garry
2024-10-04 14:40       ` Keith Busch
2024-10-06  6:58       ` Suraj Sonawane
2024-10-06  7:11         ` Suraj Sonawane
2024-10-04 14:39     ` Keith Busch
2024-10-06  7:03       ` Suraj Sonawane
2024-10-07  5:50         ` Christoph Hellwig
2024-10-07 19:58 ` [PATCH v2] block: Fix uninitialized symbol 'bio' " SurajSonawane2415
2024-10-08  4:23   ` Christoph Hellwig
2024-10-08 12:04 ` [PATCH v3] " SurajSonawane2415
2024-10-08 12:06   ` Christoph Hellwig [this message]
2024-10-08 14:52   ` Keith Busch
2024-10-08 15:35     ` Keith Busch
2024-10-08 17:52 ` [PATCH v4] " SurajSonawane2415
2024-10-09  7:30   ` Christoph Hellwig
2024-10-09 11:00     ` Suraj Sonawane
2024-10-09 11:37       ` Christoph Hellwig
2024-10-09 11:40         ` Suraj Sonawane
2024-11-15 16:07   ` Suraj Sonawane
2024-11-15 16:10     ` Jens Axboe
2024-11-16 11:32       ` Suraj Sonawane
2024-11-18  6:28         ` Christoph Hellwig
2024-11-19 16:53           ` Suraj Sonawane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZwUgO-ASFxcSa1b6@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=surajsonawane0215@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.