From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>,
James Clark <james.clark@linaro.org>,
Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linux.dev>,
Yicong Yang <yangyicong@hisilicon.com>,
Weilin Wang <weilin.wang@intel.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Sumanth Korikkar <sumanthk@linux.ibm.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/8] CSV/JSON metric thresholds, fix printf modifiers
Date: Tue, 8 Oct 2024 15:47:55 -0700 [thread overview]
Message-ID: <ZwW2m5D2cnIabE_z@google.com> (raw)
In-Reply-To: <20241004234120.1495209-1-irogers@google.com>
Hi Ian,
On Fri, Oct 04, 2024 at 04:41:12PM -0700, Ian Rogers wrote:
> Metric thresholds are being computed for CSV and JSON output but not
> displayed. Rename the color that encodes the threshold as enum values
> and use to generate string constants in a CSV column or json
> dictionary value.
IIUC it'd show "good" or "bad" when the metric defines a threshold and
show "good", "less good", "nearly bad" or "bad" for the legacy shadow
stats? Anyway it's nice to show if the value is good or not.
>
> Add printf attribute to functions in color.h that could support
> it. Fix bad printf format strings that this detected.
>
> Ian Rogers (8):
> perf color: Add printf format checking and resolve issues
> perf stat: Fix/add parameter names for print_metric
> perf stat: Display "none" for NaN with metric only json
> perf stat: Drop metric-unit if unit is NULL
> perf stat: Change color to threshold in print_metric
> perf stat: Display metric threshold value in CSV output
> perf stat: Add metric-threshold to json output
> perf stat: Disable metric thresholds for CSV/JSON metric-only mode
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
>
> tools/perf/Documentation/perf-stat.txt | 1 +
> tools/perf/arch/x86/util/iostat.c | 2 +-
> tools/perf/builtin-sched.c | 2 +-
> tools/perf/builtin-script.c | 6 +-
> tools/perf/builtin-stat.c | 8 ++
> tools/perf/builtin-trace.c | 2 +-
> .../tests/shell/lib/perf_json_output_lint.py | 5 +-
> tools/perf/tests/shell/stat+csv_output.sh | 24 ++--
> tools/perf/util/arm-spe.c | 2 +-
> tools/perf/util/color.h | 9 +-
> tools/perf/util/intel-bts.c | 2 +-
> tools/perf/util/intel-pt.c | 2 +-
> tools/perf/util/s390-cpumsf.c | 2 +-
> tools/perf/util/s390-sample-raw.c | 6 +-
> tools/perf/util/stat-display.c | 85 +++++++++---
> tools/perf/util/stat-shadow.c | 128 ++++++++++--------
> tools/perf/util/stat.h | 16 ++-
> 17 files changed, 191 insertions(+), 111 deletions(-)
>
> --
> 2.47.0.rc0.187.ge670bccf7e-goog
>
next prev parent reply other threads:[~2024-10-08 22:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 23:41 [PATCH v1 0/8] CSV/JSON metric thresholds, fix printf modifiers Ian Rogers
2024-10-04 23:41 ` [PATCH v1 1/8] perf color: Add printf format checking and resolve issues Ian Rogers
2024-10-04 23:41 ` [PATCH v1 2/8] perf stat: Fix/add parameter names for print_metric Ian Rogers
2024-10-04 23:41 ` [PATCH v1 3/8] perf stat: Display "none" for NaN with metric only json Ian Rogers
2024-10-08 22:38 ` Namhyung Kim
2024-10-08 23:38 ` Ian Rogers
2024-10-04 23:41 ` [PATCH v1 4/8] perf stat: Drop metric-unit if unit is NULL Ian Rogers
2024-10-08 23:27 ` Tim Chen
2024-10-08 23:33 ` Ian Rogers
2024-10-04 23:41 ` [PATCH v1 5/8] perf stat: Change color to threshold in print_metric Ian Rogers
2024-10-04 23:41 ` [PATCH v1 6/8] perf stat: Display metric threshold value in CSV output Ian Rogers
2024-10-04 23:41 ` [PATCH v1 7/8] perf stat: Add metric-threshold to json output Ian Rogers
2024-10-04 23:41 ` [PATCH v1 8/8] perf stat: Disable metric thresholds for CSV/JSON metric-only mode Ian Rogers
2024-10-08 22:47 ` Namhyung Kim [this message]
2024-10-08 23:40 ` [PATCH v1 0/8] CSV/JSON metric thresholds, fix printf modifiers Ian Rogers
2024-10-10 0:59 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwW2m5D2cnIabE_z@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sumanthk@linux.ibm.com \
--cc=tim.c.chen@linux.intel.com \
--cc=tmricht@linux.ibm.com \
--cc=weilin.wang@intel.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.