All of lore.kernel.org
 help / color / mirror / Atom feed
From: Isaac Manjarres <isaacmanjarres@google.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	John Ogness <john.ogness@linutronix.de>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	surenb@google.com, kernel-team@android.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] printk: Improve memory usage logging during boot
Date: Wed, 16 Oct 2024 09:38:31 -0700	[thread overview]
Message-ID: <Zw_sB7wK97w4Y0Fe@google.com> (raw)
In-Reply-To: <Zw-USn7PUHwCIGfL@pathway.suse.cz>

On Wed, Oct 16, 2024 at 12:24:35PM +0200, Petr Mladek wrote:
> I am sorry for the delay and thanks for the reminder. Last weeks were
> a bit hectic...
> 
> Anyway, I have just comitted the patch into printk/linux.git,
> branch for-6.13.
> 
> Note:
> 
> I have updated the sample messages in the commit message as suggested
> earlier.
> 
> Also I double checked the patch and simplified the comment
> in the following hunk. The original one was a bit cryptic.
> 
> @@ -1185,20 +1196,25 @@ void __init setup_log_buf(int early)
>  	if (!early && !new_log_buf_len)
>  		log_buf_add_cpu();
>  
> -	if (!new_log_buf_len)
> +	if (!new_log_buf_len) {
> +		/* Show the memory stats only once. */
> +		if (!early)
> +			goto out;
> +
>  		return;
> +	}
> 
> , see also
> https://git.kernel.org/pub/scm/linux/kernel/git/printk/linux.git/commit/?h=for-6.13&id=a961ec4e2860af4933e8c1763fe4f038c2d6ac80
> 
> Best Regards,
> Petr

No worries! I completely understand. Thank you for merging the patch
into your tree, and for cleaning up the commit message/comment.

Thanks,
Isaac

  reply	other threads:[~2024-10-16 16:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 18:48 [PATCH v2] printk: Improve memory usage logging during boot Isaac J. Manjarres
2024-10-01 15:46 ` Petr Mladek
2024-10-02 18:04   ` Isaac Manjarres
2024-10-15 12:47     ` Isaac Manjarres
2024-10-16 10:24       ` Petr Mladek
2024-10-16 16:38         ` Isaac Manjarres [this message]
2024-12-01 11:40   ` Geert Uytterhoeven
2024-12-03  9:42     ` Petr Mladek
2024-12-04 17:17       ` John Ogness

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zw_sB7wK97w4Y0Fe@google.com \
    --to=isaacmanjarres@google.com \
    --cc=john.ogness@linutronix.de \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=surenb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.