From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: John Stultz <jstultz@google.com>, tglx@linutronix.de
Cc: sboyd@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource: Remove unused clocksource_change_rating
Date: Thu, 10 Oct 2024 01:22:00 +0000 [thread overview]
Message-ID: <ZwcsOMV6kofmpduf@gallifrey> (raw)
In-Reply-To: <CANDhNCr=+x3fJo1dhyWnSGGLtexXLcTuHj8OEPqbj_TcDWdEPA@mail.gmail.com>
* John Stultz (jstultz@google.com) wrote:
> On Tue, Oct 8, 2024 at 5:30 PM <linux@treblig.org> wrote:
> >
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > clocksource_change_rating() has been unused since 2017's commit
> > 63ed4e0c67df ("Drivers: hv: vmbus: Consolidate all Hyper-V specific clocksource code")
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>
> Thanks for submitting this cleanup!
>
> Untested, but
> Acked-by: John Stultz <jstultz@google.com>
Hmm the test robot got an unused warning on __clocksource_change_rating
I think that's because it's an allnoconfig and that needs moving inside
the ifdef.
I'll look at it.
Dave
> thanks
> -john
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2024-10-10 1:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 0:30 [PATCH] clocksource: Remove unused clocksource_change_rating linux
2024-10-09 1:20 ` John Stultz
2024-10-10 1:22 ` Dr. David Alan Gilbert [this message]
2024-10-10 13:59 ` Dr. David Alan Gilbert
2024-10-09 9:21 ` [tip: timers/core] " tip-bot2 for Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwcsOMV6kofmpduf@gallifrey \
--to=linux@treblig.org \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.