From: Patrick Steinhardt <ps@pks.im>
To: Andrew Kreimer <algonell@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/7] compat: fix typos
Date: Thu, 10 Oct 2024 08:55:08 +0200 [thread overview]
Message-ID: <Zwd6TGeksR9UiM8i@pks.im> (raw)
In-Reply-To: <20241009114940.520486-2-algonell@gmail.com>
On Wed, Oct 09, 2024 at 02:49:34PM +0300, Andrew Kreimer wrote:
> diff --git a/compat/regex/regexec.c b/compat/regex/regexec.c
> index e92be5741d..15ab2d1d40 100644
> --- a/compat/regex/regexec.c
> +++ b/compat/regex/regexec.c
> @@ -292,7 +292,7 @@ compat_symbol (libc, __compat_regexec, regexec, GLIBC_2_0);
> concerned.
>
> If REGS is not NULL, and BUFP->no_sub is not set, the offsets of the match
> - and all groups is stroed in REGS. (For the "_2" variants, the offsets are
> + and all groups is stored in REGS. (For the "_2" variants, the offsets are
> computed relative to the concatenation, not relative to the individual
> strings.)
>
Do we want to fix grammar while at it? s/all group is/all group are/
In any case, this and all of the other patches look good to me. Thanks!
Patrick
next prev parent reply other threads:[~2024-10-10 6:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 11:49 [PATCH 0/7] Fix typos Andrew Kreimer
2024-10-09 11:49 ` [PATCH 1/7] compat: fix typos Andrew Kreimer
2024-10-10 6:55 ` Patrick Steinhardt [this message]
2024-10-10 15:14 ` Andrew Kreimer
2024-10-09 11:49 ` [PATCH 2/7] contrib: " Andrew Kreimer
2024-10-09 11:49 ` [PATCH 3/7] git-gui: Fix typos Andrew Kreimer
2024-10-09 11:49 ` [PATCH 4/7] t: fix typos Andrew Kreimer
2024-10-09 11:49 ` [PATCH 5/7] t/perf: " Andrew Kreimer
2024-10-09 11:49 ` [PATCH 6/7] t/unit-tests: " Andrew Kreimer
2024-10-09 11:49 ` [PATCH 7/7] t/helper: fix a typo Andrew Kreimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zwd6TGeksR9UiM8i@pks.im \
--to=ps@pks.im \
--cc=algonell@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.