Re: [PATCH v5 08/16] crypto/hash: Implement and use new hash API

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Oct 08, 2024 at 09:57:15AM +0200, Cédric Le Goater wrote:
> From: Alejandro Zeise <alejandro.zeise@seagate.com>
> 
> Changes the public hash API implementation to support accumulative hashing.
> 
> Implementations for the public functions are added to call the new
> driver functions that implement context creation, updating,
> finalization, and destruction.
> 
> Additionally changes the "shortcut" functions to use these 4 new core
> functions.
> 
> Signed-off-by: Alejandro Zeise <alejandro.zeise@seagate.com>
> [ clg: - Reworked qcrypto_hash_bytesv() error handling
>        - Used hash->driver int qcrypto_hash_new(), qcrypto_hash_free()
>          qcrypto_hash_updatev()
>        - Introduced qcrypto_hash_supports() check in
>          qcrypto_hash_new()
>        - Introduced g_autofree variables in qcrypto_hash_finalize_digest()
>          and qcrypto_hash_finalize_base64()
>        - Re-arrranged code in qcrypto_hash_digestv() and
>          qcrypto_hash_digest()
>        - Checkpatch fixes ]
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>  crypto/hash.c | 161 ++++++++++++++++++++++++++++++++++++++++----------
>  1 file changed, 131 insertions(+), 30 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|