From: Namhyung Kim <namhyung@kernel.org>
To: Leo Yan <leo.yan@arm.com>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
"Liang, Kan" <kan.liang@linux.intel.com>,
James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/5] perf cpumap: Correct for perf_cpu_map__merge()
Date: Thu, 10 Oct 2024 09:10:57 -0700 [thread overview]
Message-ID: <Zwf8kTiphIRniYw9@google.com> (raw)
In-Reply-To: <0a0bebe6-b104-4a84-9415-68fdee086a5f@arm.com>
On Thu, Oct 10, 2024 at 04:01:21PM +0100, Leo Yan wrote:
> On 9/25/24 20:53, Leo Yan wrote:
> > perf_cpu_map__merge() has two arguments, 'orig' and 'other', as
> > described in its original comment:
> >
> > "orig either gets freed and replaced with a new map, or reused
> > with no reference count change (similar to "realloc")
> > other has its reference count increased."
> >
> > This causes confusion due to the different reference counting on the CPU
> > map objects, which complicates its usage and makes maintenance
> > difficult. We also discussed this in the email [1].
> >
> > This patch series makes that a new CPU map is allocated for the
> > merging result, or the reference count is increased if an existing CPU
> > map is reused. This means that once perf_cpu_map__merge() is invoked,
> > the caller gains ownership of the resulting map and must release it
> > with perf_cpu_map__put().
>
> Gentle ping ...
Ian and Adrian, can you please review this patchset?
Thanks,
Namhyung
prev parent reply other threads:[~2024-10-10 16:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 19:53 [PATCH v1 0/5] perf cpumap: Correct for perf_cpu_map__merge() Leo Yan
2024-09-25 19:53 ` [PATCH v1 1/5] libperf cpumap: Correct reference count " Leo Yan
2024-10-10 17:41 ` Adrian Hunter
2024-10-11 9:34 ` Leo Yan
2024-10-11 9:40 ` Leo Yan
2024-10-11 9:46 ` Adrian Hunter
2024-10-11 9:51 ` Leo Yan
2024-09-25 19:53 ` [PATCH v1 2/5] perf: Release old CPU maps after merging Leo Yan
2024-09-25 19:53 ` [PATCH v1 3/5] perf cpumap: Update CPU map merging test Leo Yan
2024-09-25 19:53 ` [PATCH v1 4/5] perf cpumap: Add more tests for CPU map merging Leo Yan
2024-09-25 19:53 ` [PATCH v1 5/5] perf cpumap: Add checking for reference counter Leo Yan
2024-10-10 15:01 ` [PATCH v1 0/5] perf cpumap: Correct for perf_cpu_map__merge() Leo Yan
2024-10-10 16:10 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zwf8kTiphIRniYw9@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.