From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] net: dsa: mv88e6xxx: leds: fix led refcount in error path
Date: Thu, 10 Oct 2024 17:30:42 +0300 [thread overview]
Message-ID: <ZwflEqdeQ43Wgn2K@smile.fi.intel.com> (raw)
In-Reply-To: <20241008-mv88e6xxx_leds_fwnode_put-v1-2-cfd7758cd176@gmail.com>
On Tue, Oct 08, 2024 at 06:10:28PM +0200, Javier Carrasco wrote:
> The 'led' fwnode_handle within fwnode_for_each_child_node() must be
> released upon early exits by means of an explicit call to
> fwnode_handle_put(), which in this case is missing.
>
> Instead of adding the missing call, and considering that this driver was
> recently introduced, use a scoped variant of the loop to automatically
> decrement the child's refcount when it goes out of scope.
>
> Note that the _avaialable_ version of the loop has been used, as there
> is no apparent reason to walk over unavailable nodes.
...
> - struct fwnode_handle *led = NULL, *leds = NULL;
> + struct fwnode_handle *leds = NULL;
Can it be const now?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-10 14:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 16:10 [PATCH net-next 0/3] net, device property: fix led node releases in mv88e6xxx with new macro Javier Carrasco
2024-10-08 16:10 ` [PATCH net-next 1/3] device property: Introduce fwnode_for_each_available_child_node_scoped() Javier Carrasco
2024-10-10 14:32 ` Andy Shevchenko
2024-10-11 5:39 ` Sakari Ailus
2024-10-11 8:34 ` Javier Carrasco
2024-10-11 9:54 ` Sakari Ailus
2024-10-11 12:04 ` Javier Carrasco
2024-10-08 16:10 ` [PATCH net-next 2/3] net: dsa: mv88e6xxx: leds: fix led refcount in error path Javier Carrasco
2024-10-08 16:38 ` Andrew Lunn
2024-10-10 14:30 ` Andy Shevchenko [this message]
2024-10-08 16:10 ` [PATCH net-next 3/3] net: dsa: mv88e6xxx: leds: fix leds refcount Javier Carrasco
2024-10-08 16:40 ` Andrew Lunn
2024-10-08 23:31 ` Javier Carrasco
2024-10-10 14:33 ` Andy Shevchenko
2024-10-10 19:15 ` Javier Carrasco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwflEqdeQ43Wgn2K@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=djrscally@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.