From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Philipp Stanner <pstanner@redhat.com>
Cc: "Heiner Kallweit" <hkallweit1@gmail.com>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Niklas Cassel" <cassel@kernel.org>,
"Sergey Shtylyov" <s.shtylyov@omp.ru>,
"Basavaraj Natikar" <basavaraj.natikar@amd.com>,
"Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <bentiss@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Alex Dubov" <oakad@yahoo.com>,
"Sudarsana Kalluru" <skalluru@marvell.com>,
"Manish Chopra" <manishc@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rasesh Mody" <rmody@marvell.com>,
GR-Linux-NIC-Dev@marvell.com,
"Igor Mitsyanko" <imitsyanko@quantenna.com>,
"Sergey Matyukevich" <geomatsi@gmail.com>,
"Kalle Valo" <kvalo@kernel.org>,
"Sanjay R Mehta" <sanju.mehta@amd.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Jon Mason" <jdmason@kudzu.us>,
"Dave Jiang" <dave.jiang@intel.com>,
"Allen Hubbe" <allenbh@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Juergen Gross" <jgross@suse.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Chen Ni" <nichen@iscas.ac.cn>, "Ricky Wu" <ricky_wu@realtek.com>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Breno Leitao" <leitao@debian.org>,
"Kevin Tian" <kevin.tian@intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Mostafa Saleh" <smostafa@google.com>,
"Hannes Reinecke" <hare@suse.de>,
"John Garry" <john.g.garry@oracle.com>,
"Soumya Negi" <soumya.negi97@gmail.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>, "Yi Liu" <yi.l.liu@intel.com>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
"Christian Brauner" <brauner@kernel.org>,
"Ankit Agrawal" <ankita@nvidia.com>,
"Reinette Chatre" <reinette.chatre@intel.com>,
"Eric Auger" <eric.auger@redhat.com>,
"Ye Bin" <yebin10@huawei.com>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.dev>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Rui Salvaterra" <rsalvaterra@gmail.com>,
"Marc Zyngier" <maz@kernel.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, ntb@lists.linux.dev,
linux-pci@vger.kernel.org, linux-staging@lists.linux.dev,
kvm@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-sound@vger.kernel.org
Subject: Re: [RFC PATCH 00/13] Remove implicit devres from pci_intx()
Date: Thu, 10 Oct 2024 17:50:25 +0300 [thread overview]
Message-ID: <ZwfpsSxnwm7K4eMF@smile.fi.intel.com> (raw)
In-Reply-To: <6468cf3e4a06c008644c98a7a79f81a1c04752b8.camel@redhat.com>
On Thu, Oct 10, 2024 at 10:09:12AM +0200, Philipp Stanner wrote:
> On Wed, 2024-10-09 at 20:32 +0200, Heiner Kallweit wrote:
> > On 09.10.2024 10:35, Philipp Stanner wrote:
...
> > > To do so, a pci_intx() version that is always-managed, and one that
> > > is
> > > never-managed are provided. Then, all pci_intx() users are ported
> > > to the
> > > version they need. Afterwards, pci_intx() can be cleaned up and the
> > > users of the never-managed version be ported back to pci_intx().
> > >
> > > This way we'd get this PCI API consistent again.
> > >
> > AFAICS pci_intx() is used only by drivers which haven't been
> > converted
> > to the pci_alloc_irq_vectors() API yet. Wouldn't it be better to do
> > this
> > instead of trying to improve pci_intx()?
My first impression was the same...
> This would be the créme-de-la-créme-solution, yes.
>
> But such a portation would require more detailed knowledge of the old
> drivers.
>
> In this discussion, Alex points out that at least in some drivers, you
> can't replace pci_intx() without further ado:
> https://lore.kernel.org/all/20240904151020.486f599e.alex.williamson@redhat.com/
>
> What we could do is mark pci_intx() and pcim_intx() as deprecated and
> point everyone to pci_alloc_irq_vectors(). Then someone can look into
> porting the old drivers at some point in the future.
...but here I got the point by Philipp.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-10-10 14:50 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 8:35 [RFC PATCH 00/13] Remove implicit devres from pci_intx() Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 01/13] PCI: Prepare removing " Philipp Stanner
2024-10-09 9:10 ` Damien Le Moal
2024-10-10 14:40 ` Andy Shevchenko
2024-10-11 12:16 ` Philipp Stanner
2024-10-11 13:50 ` Andy Shevchenko
2024-10-14 9:12 ` Philipp Stanner
2024-10-10 17:43 ` Alex Williamson
2024-10-11 12:03 ` Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 02/13] ALSA: hda: hda_intel: Use always-managed version of pcim_intx() Philipp Stanner
2024-10-10 14:46 ` Andy Shevchenko
2024-10-11 12:27 ` Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 03/13] drivers/xen: Use never-managed version of pci_intx() Philipp Stanner
2024-10-09 8:51 ` Juergen Gross
2024-10-09 10:50 ` Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 04/13] net/ethernet: " Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 05/13] net/ntb: " Philipp Stanner
2024-10-10 4:37 ` Shyam Sundar S K
2024-10-10 4:42 ` Shyam Sundar S K
2024-10-09 8:35 ` [RFC PATCH 06/13] misc: " Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 07/13] vfio/pci: " Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 08/13] PCI: MSI: " Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 09/13] ata: Use always-managed " Philipp Stanner
2024-10-09 8:51 ` Damien Le Moal
2024-10-09 10:55 ` Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 10/13] staging: rts5280: " Philipp Stanner
2024-10-09 9:38 ` Greg Kroah-Hartman
2024-10-09 19:41 ` Philipp Hortmann
2024-10-10 8:03 ` Philipp Stanner
2024-10-10 9:03 ` Greg Kroah-Hartman
2024-10-10 9:12 ` Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 11/13] wifi: qtnfmac: use always-managed version of pcim_intx() Philipp Stanner
2024-10-09 8:35 ` [RFC PATCH 12/13] HID: amd_sfh: Use " Philipp Stanner
2024-10-10 7:20 ` Basavaraj Natikar
2024-10-09 8:35 ` [RFC PATCH 13/13] Remove devres from pci_intx() Philipp Stanner
2024-10-10 8:50 ` Dan Carpenter
2024-10-10 9:11 ` Philipp Stanner
2024-10-10 17:43 ` Alex Williamson
2024-10-10 18:34 ` Dan Carpenter
2024-10-11 12:07 ` Philipp Stanner
2024-10-09 18:32 ` [RFC PATCH 00/13] Remove implicit " Heiner Kallweit
2024-10-10 8:09 ` Philipp Stanner
2024-10-10 14:50 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwfpsSxnwm7K4eMF@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=alex.williamson@redhat.com \
--cc=allenbh@gmail.com \
--cc=ankita@nvidia.com \
--cc=arnd@arndb.de \
--cc=basavaraj.natikar@amd.com \
--cc=bentiss@kernel.org \
--cc=bhelgaas@google.com \
--cc=brauner@kernel.org \
--cc=cassel@kernel.org \
--cc=dave.jiang@intel.com \
--cc=davem@davemloft.net \
--cc=dlemoal@kernel.org \
--cc=edumazet@google.com \
--cc=eric.auger@redhat.com \
--cc=geomatsi@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hkallweit1@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=imitsyanko@quantenna.com \
--cc=jdmason@kudzu.us \
--cc=jgg@ziepe.ca \
--cc=jgross@suse.com \
--cc=jikos@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kevin.tian@intel.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=leitao@debian.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@treblig.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=manishc@marvell.com \
--cc=mario.limonciello@amd.com \
--cc=marmarek@invisiblethingslab.com \
--cc=maz@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=ntb@lists.linux.dev \
--cc=oakad@yahoo.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=pabeni@redhat.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=pstanner@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=ricky_wu@realtek.com \
--cc=rmody@marvell.com \
--cc=rsalvaterra@gmail.com \
--cc=s.shtylyov@omp.ru \
--cc=sanju.mehta@amd.com \
--cc=skalluru@marvell.com \
--cc=smostafa@google.com \
--cc=soumya.negi97@gmail.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xen-devel@lists.xenproject.org \
--cc=yebin10@huawei.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.