Re: [nft PATCH] tests: shell: Join arithmetic statements in maps/vmap_timeout

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Fri, Oct 11, 2024 at 11:25:08AM +0200, Phil Sutter wrote:
> In light of the recent typo fix, go an extra step and merge the modulo
> and offset adjustment in a single term.

LGTM.

> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
>  tests/shell/testcases/maps/vmap_timeout | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/shell/testcases/maps/vmap_timeout b/tests/shell/testcases/maps/vmap_timeout
> index 6d73f3cc9ae24..8ac7e8e7684ab 100755
> --- a/tests/shell/testcases/maps/vmap_timeout
> +++ b/tests/shell/testcases/maps/vmap_timeout
> @@ -9,8 +9,7 @@ $NFT -f $dumpfile
>  
>  port=23
>  for i in $(seq 1 100) ; do
> -	timeout=$((RANDOM%5))
> -	timeout=$((timeout+1))
> +	timeout=$((RANDOM % 5 + 1))
>  	expire=$((RANDOM%timeout))
>  	j=1
>  
> @@ -28,11 +27,9 @@ for i in $(seq 1 100) ; do
>  
>  	port=$((port + 1))
>  	for j in $(seq 2 400); do
> -		timeout=$((RANDOM%5))
> -		timeout=$((timeout+1))
> +		timeout=$((RANDOM % 5 + 1))
>  		expire=$((RANDOM%timeout))
> -		utimeout=$((RANDOM%5))
> -		utimeout=$((utimeout+1))
> +		utimeout=$((RANDOM % 5 + 1))
>  
>  		timeout_str="timeout ${timeout}s"
>  		expire_str=""
> -- 
> 2.43.0
>