All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: Sam James <sam@gentoo.org>
Cc: dtrace@lists.linux.dev
Subject: Re: [PATCH 3/3] test: fix exit code in tst.newprobes.sh
Date: Fri, 11 Oct 2024 23:29:31 -0400	[thread overview]
Message-ID: <ZwntG33P5oU7pt9t@oracle.com> (raw)
In-Reply-To: <6ab9502eb62a6d4be913b5032fd6b1f54fe7627f.1724112622.git.sam@gentoo.org>

On Tue, Aug 20, 2024 at 01:10:22AM +0100, Sam James wrote:
> $status is never assigned, just use $?.

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

... and committed with Signed-off-by added.

> ---
>  test/unittest/pid/tst.newprobes.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/unittest/pid/tst.newprobes.sh b/test/unittest/pid/tst.newprobes.sh
> index a4944688..0980d3b3 100755
> --- a/test/unittest/pid/tst.newprobes.sh
> +++ b/test/unittest/pid/tst.newprobes.sh
> @@ -44,4 +44,4 @@ tick-1s
>  }
>  EOF
>  
> -exit $status
> +exit $?
> -- 
> 2.46.0
> 

  parent reply	other threads:[~2024-10-12  3:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20  0:10 [PATCH 0/3] Test exit code fixlets Sam James
2024-08-20  0:10 ` [PATCH 1/3] test: fix exit code in tst.ipv4remotetcp.sh Sam James
2024-10-12  3:29   ` Kris Van Hees
2024-08-20  0:10 ` [PATCH 2/3] test: fix exit code typo in tst.core.sh Sam James
2024-10-12  3:29   ` Kris Van Hees
2024-08-20  0:10 ` [PATCH 3/3] test: fix exit code in tst.newprobes.sh Sam James
2024-08-20  2:14   ` Eugene Loh
2024-10-12  3:29   ` Kris Van Hees [this message]
2024-10-12  3:55     ` Eugene Loh
2024-10-12  4:13       ` Kris Van Hees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZwntG33P5oU7pt9t@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.