From: Kris Van Hees <kris.van.hees@oracle.com>
To: Sam James <sam@gentoo.org>
Cc: dtrace@lists.linux.dev
Subject: Re: [PATCH 2/6] test: fix broken shebang in tst.plddGrab32.sh
Date: Fri, 11 Oct 2024 23:30:04 -0400 [thread overview]
Message-ID: <ZwntPCJF9sU7EgYA@oracle.com> (raw)
In-Reply-To: <fdd1e771719e70c32b6870d15fe77e2a8afb6777.1724962546.git.sam@gentoo.org>
On Thu, Aug 29, 2024 at 09:15:42PM +0100, Sam James wrote:
> shellcheck reports:
> ```
> In test/internals/libproc/tst.plddGrab32.sh line 2:
> #!/bin/bash
> ^-- SC1128 (error): The shebang must be on the first line. Delete blanks and move comments.
> ```
Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>
... and committed with Signed-off-by added.
> ---
> test/internals/libproc/tst.plddGrab32.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/test/internals/libproc/tst.plddGrab32.sh b/test/internals/libproc/tst.plddGrab32.sh
> index a22e2367..c69213ac 100755
> --- a/test/internals/libproc/tst.plddGrab32.sh
> +++ b/test/internals/libproc/tst.plddGrab32.sh
> @@ -1,4 +1,3 @@
> -
> #!/bin/bash
> #
> # Oracle Linux DTrace.
> --
> 2.46.0
>
next prev parent reply other threads:[~2024-10-12 3:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 20:15 [PATCH 1/6] test: fix missing line continuation in tst.perf-types.sh Sam James
2024-08-29 20:15 ` [PATCH 2/6] test: fix broken shebang in tst.plddGrab32.sh Sam James
2024-10-12 3:30 ` Kris Van Hees [this message]
2024-08-29 20:15 ` [PATCH 3/6] test: awk -> gawk where we use strtonum Sam James
2024-10-12 3:30 ` Kris Van Hees
2024-08-29 20:15 ` [PATCH 4/6] test: fix 'CPU' typo Sam James
2024-10-12 3:30 ` Kris Van Hees
2024-08-29 20:15 ` [PATCH 5/6] test: libproc: cater to merged-usr systems Sam James
2024-10-12 3:30 ` Kris Van Hees
2024-08-29 20:15 ` [PATCH 6/6] test: awk -> gawk universally Sam James
2024-10-12 3:31 ` Kris Van Hees
2024-10-12 3:29 ` [PATCH 1/6] test: fix missing line continuation in tst.perf-types.sh Kris Van Hees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwntPCJF9sU7EgYA@oracle.com \
--to=kris.van.hees@oracle.com \
--cc=dtrace@lists.linux.dev \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.