All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Marek Vasut <marex@denx.de>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH] [RFC] PCI/PM: Do not RPM suspend devices without drivers
Date: Sun, 13 Oct 2024 13:03:56 +0200	[thread overview]
Message-ID: <ZwupHAAwTo5mDyyA@wunner.de> (raw)
In-Reply-To: <20241012004857.218874-1-marex@denx.de>

On Sat, Oct 12, 2024 at 02:48:48AM +0200, Marek Vasut wrote:
> The pci_host_probe() does reallocate BARs for devices which start up with
> uninitialized BAR addresses set to 0 by calling pci_bus_assign_resources(),
> which updates the device config space content.
> 
> At the same time, pci_pm_runtime_suspend() triggers pci_save_state() for
> all devices which do not have drivers assigned to them to store current
> content of their config space registers.
[...]
> Work around the issue by not suspending pci_bus_type devices which do
> not have driver assigned to them, keep those devices active to prevent
> pci_save_state() from being called. Once a proper driver takes over, it
> can RPM manage the device correctly.

It sounds like you may want to acquire a runtime PM reference
or disable runtime PM for the duration of the bus scan (or at
least device scan) rather than the proposed workaround.

Thanks,

Lukas

  parent reply	other threads:[~2024-10-13 11:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-12  0:48 [PATCH] [RFC] PCI/PM: Do not RPM suspend devices without drivers Marek Vasut
2024-10-12  0:59 ` Marek Vasut
2024-10-13 11:03 ` Lukas Wunner [this message]
2024-10-26  0:19   ` Marek Vasut
2024-10-28 17:52     ` Wysocki, Rafael J
2024-10-28 18:25       ` Marek Vasut
2024-10-29 18:57         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZwupHAAwTo5mDyyA@wunner.de \
    --to=lukas@wunner.de \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.