All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Maciej Strozek <mstrozek@opensource.cirrus.com>
Cc: <perex@perex.cz>, <alsa-devel@alsa-project.org>,
	<patches@opensource.cirrus.com>
Subject: Re: [PATCH alsa-ucm-conf v3 1/2] sof-soundwire: Change map control names to make them unique and user friendly
Date: Mon, 14 Oct 2024 10:53:20 +0100	[thread overview]
Message-ID: <ZwzqEO3lokmsoBbC@opensource.cirrus.com> (raw)
In-Reply-To: <20241011105710.1998823-1-mstrozek@opensource.cirrus.com>

On Fri, Oct 11, 2024 at 11:57:09AM +0100, Maciej Strozek wrote:
> Both 'Speaker Digital' and 'cs42l43 PDM2' names were found in other alsa
> controls, confusing the MixerElems paths. Make them unique to avoid errors for
> hardware mutes. Also add 'Capture' string into microphone controls to make
> them work properly.
> 
> Signed-off-by: Maciej Strozek <mstrozek@opensource.cirrus.com>
> ---

Both patches look good to me:

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

      parent reply	other threads:[~2024-10-14  9:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11 10:57 [PATCH alsa-ucm-conf v3 1/2] sof-soundwire: Change map control names to make them unique and user friendly Maciej Strozek
2024-10-11 10:57 ` [PATCH alsa-ucm-conf v3 2/2] sof-soundwire: Add sequence for controlling Mic Mute LED Maciej Strozek
2024-10-14  9:53 ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZwzqEO3lokmsoBbC@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=mstrozek@opensource.cirrus.com \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.