Re: [PATCH 7/9] drm/i915: Nuke ADL pre-production Wa_22011186057

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, Oct 24, 2024 at 10:52:13AM +0000, Hogander, Jouni wrote:
> On Wed, 2024-10-09 at 21:22 +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Wa_22011186057 (some CCS problem) only affected ADL A-stepping,
> > which I presume is pre-production hw. Drop the dead code.
> 
> Maybe you could add? :
> 
> Bspec: 54369

Can do.

> 
> BR,
> 
> Jouni Högander
> 
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/skl_universal_plane.c | 8 --------
> >  1 file changed, 8 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > index ea72c54e8329..c85bb1fea92f 100644
> > --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > @@ -2562,10 +2562,6 @@ skl_plane_disable_flip_done(struct intel_plane
> > *plane)
> >  static bool skl_plane_has_rc_ccs(struct drm_i915_private *i915,
> >                                  enum pipe pipe, enum plane_id
> > plane_id)
> >  {
> > -       /* Wa_22011186057 */
> > -       if (IS_ALDERLAKE_P(i915) && IS_DISPLAY_STEP(i915, STEP_A0,
> > STEP_B0))
> > -               return false;
> > -
> >         if (DISPLAY_VER(i915) >= 11)
> >                 return true;
> >  
> > @@ -2587,10 +2583,6 @@ static bool tgl_plane_has_mc_ccs(struct
> > drm_i915_private *i915,
> >                 (IS_TIGERLAKE(i915) && IS_DISPLAY_STEP(i915, STEP_A0,
> > STEP_D0)))
> >                 return false;
> >  
> > -       /* Wa_22011186057 */
> > -       if (IS_ALDERLAKE_P(i915) && IS_DISPLAY_STEP(i915, STEP_A0,
> > STEP_B0))
> > -               return false;
> > -
> >         return plane_id < PLANE_6;
> >  }
> >  
> 

-- 
Ville Syrjälä
Intel