From: Taylor Blau <me@ttaylorr.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Victoria Dye <vdye@github.com>,
Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH] ref-filter: format iteratively with lexicographic refname sorting
Date: Wed, 16 Oct 2024 18:11:47 -0400 [thread overview]
Message-ID: <ZxA6I67FfPe4fV2F@nand.local> (raw)
In-Reply-To: <a873ed828ccae426214cc8f87610df97ff9a269e.1729055871.git.ps@pks.im>
On Wed, Oct 16, 2024 at 08:00:30AM +0200, Patrick Steinhardt wrote:
> But there is one exception here where we _can_ get away with sorting
> refs while streaming: ref backends sort references returned by their
> iterators in lexicographic order. So if the following conditions are all
> true we can do iterative streaming:
>
> - The caller uses at most a single name pattern. Otherwise we'd have
> to sort results from multiple invocations of the iterator.
>
> - There must be at most a single sorting specification, as otherwise
> we're not using plain lexicographic ordering.
>
> - The sorting specification must use the "refname".
>
> - The sorting specification must not be using any flags, like
> case-insensitive sorting.
Perhaps a niche case, but what about ancient packed-refs files that were
written before the 'sorted' capability was introduced?
Thanks,
Taylor
next prev parent reply other threads:[~2024-10-16 22:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 6:00 [PATCH] ref-filter: format iteratively with lexicographic refname sorting Patrick Steinhardt
2024-10-16 22:11 ` Taylor Blau [this message]
2024-10-17 2:48 ` Jeff King
2024-10-17 4:28 ` Patrick Steinhardt
2024-10-21 12:36 ` karthik nayak
2024-10-21 20:45 ` Taylor Blau
2024-10-17 5:09 ` [PATCH v2] " Patrick Steinhardt
2024-10-17 20:57 ` Taylor Blau
2024-10-21 11:10 ` Toon Claes
2024-10-21 11:33 ` Patrick Steinhardt
2024-10-21 11:33 ` [PATCH v3] " Patrick Steinhardt
2024-10-21 20:46 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxA6I67FfPe4fV2F@nand.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=stolee@gmail.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.