All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Brad Smith <brad@comstyle.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Marc-Andr_ Lureau <marcandre.lureau@redhat.com>,
	Philippe Mathieu-Daud_ <philmd@linaro.org>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [PATCH] meson.build: Remove ncurses workaround for OpenBSD
Date: Thu, 17 Oct 2024 10:52:06 +0100	[thread overview]
Message-ID: <ZxDeRtTWpsvxN3WI@redhat.com> (raw)
In-Reply-To: <ZwnvT4srOStQopOr@humpty.home.comstyle.com>

Cc'ing qemu-trivial

On Fri, Oct 11, 2024 at 11:38:55PM -0400, Brad Smith wrote:
> meson.build: Remove ncurses workaround for OpenBSD
> 
> OpenBSD 7.5 has upgraded to ncurses 6.4.
> 
> Signed-off-by: Brad Smith <brad@comstyle.com>
> ---
>  meson.build | 2 +-
>  ui/curses.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

> 
> diff --git a/meson.build b/meson.build
> index 4ea1984fc5..22e7629d81 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1374,7 +1374,7 @@ iconv = not_found
>  curses = not_found
>  if have_system and get_option('curses').allowed()
>    curses_test = '''
> -    #if defined(__APPLE__) || defined(__OpenBSD__)
> +    #ifdef __APPLE__
>      #define _XOPEN_SOURCE_EXTENDED 1
>      #endif
>      #include <locale.h>
> diff --git a/ui/curses.c b/ui/curses.c
> index ec61615f7c..4d0be9b37d 100644
> --- a/ui/curses.c
> +++ b/ui/curses.c
> @@ -38,7 +38,7 @@
>  #include "ui/input.h"
>  #include "sysemu/sysemu.h"
>  
> -#if defined(__APPLE__) || defined(__OpenBSD__)
> +#ifdef __APPLE__
>  #define _XOPEN_SOURCE_EXTENDED 1
>  #endif


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2024-10-17  9:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-12  3:38 [PATCH] meson.build: Remove ncurses workaround for OpenBSD Brad Smith
2024-10-17  9:52 ` Daniel P. Berrangé [this message]
2024-10-18 16:25 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZxDeRtTWpsvxN3WI@redhat.com \
    --to=berrange@redhat.com \
    --cc=brad@comstyle.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.