All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@vates.tech>
To: Frediano Ziglio <frediano.ziglio@cloud.com>
Cc: xen-devel@lists.xenproject.org, "Jan Beulich" <jbeulich@suse.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Julien Grall" <julien@xen.org>,
	"Stefano Stabellini" <sstabellini@kernel.org>
Subject: Re: [PATCH v6 1/5] x86/boot: create a C bundle for 32 bit boot code and use it
Date: Thu, 17 Oct 2024 16:00:54 +0000	[thread overview]
Message-ID: <ZxE0slUwETDK83PD@l14> (raw)
In-Reply-To: <20241017133123.1946204-2-frediano.ziglio@cloud.com>

On Thu, Oct 17, 2024 at 02:31:19PM +0100, Frediano Ziglio wrote:
> +$(obj)/build32.base.lds: AFLAGS-y += -DGAP=$(text_gap) -DTEXT_DIFF=$(text_diff)
> +$(obj)/build32.offset.lds: AFLAGS-y += -DGAP=$(text_gap) -DTEXT_DIFF=$(text_diff) -DFINAL

I was somehow expecting "base" and "offset" to be the other way around,
but that's fine. And by the way, -DFINAL cancel changes to GAP and
TEXT_DIFF ;-).

But overall, the changes looks nice as is,
Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>

Thanks,

-- 

Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech


  reply	other threads:[~2024-10-17 16:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17 13:31 [PATCH v6 0/5] Reuse 32 bit C code more safely Frediano Ziglio
2024-10-17 13:31 ` [PATCH v6 1/5] x86/boot: create a C bundle for 32 bit boot code and use it Frediano Ziglio
2024-10-17 16:00   ` Anthony PERARD [this message]
2024-10-18 12:42     ` Frediano Ziglio
2024-10-17 17:13   ` Andrew Cooper
2024-10-18  8:42     ` Frediano Ziglio
2024-10-18 11:49       ` Roger Pau Monné
2024-10-18 13:28         ` Frediano Ziglio
2024-10-21  8:52           ` Roger Pau Monné
2024-10-18 11:41   ` Roger Pau Monné
2024-10-18 12:04     ` Jan Beulich
2024-10-18 12:55       ` Roger Pau Monné
2024-10-18 12:48     ` Frediano Ziglio
2024-10-18 12:59       ` Roger Pau Monné
2024-10-18 13:45         ` Frediano Ziglio
2024-10-21  8:01           ` Roger Pau Monné
2024-10-17 13:31 ` [PATCH v6 2/5] x86/boot: Reuse code to relocate trampoline Frediano Ziglio
2024-10-17 14:54   ` Marek Marczykowski-Górecki
2024-10-17 13:31 ` [PATCH v6 3/5] x86/boot: Use boot_vid_info variable directly from C code Frediano Ziglio
2024-10-17 13:31 ` [PATCH v6 4/5] x86/boot: Use trampoline_phys " Frediano Ziglio
2024-10-17 13:31 ` [PATCH v6 5/5] x86/boot: Clarify comment Frediano Ziglio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZxE0slUwETDK83PD@l14 \
    --to=anthony.perard@vates.tech \
    --cc=andrew.cooper3@citrix.com \
    --cc=frediano.ziglio@cloud.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.