From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [213.95.27.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFEDF1DD862; Thu, 17 Oct 2024 12:39:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.27.120 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729168770; cv=none; b=s9b/5KD3yAI5cKijS/DfRITI1sgwJOOPg04JHPFZT+NsL8M/91AB2j/tsbWzRKdTLa2H0b2I51UVixvYyM2wgANsUbvItQk5ei3DCktzYFsdCLxdWS34crekaKxAWiwpaHcKf2tlAkGZRZINthe4W4eFQCNJRxogqCKyzhVGH+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729168770; c=relaxed/simple; bh=58ZH9EysMGctJs6VFMx8+biSi2sHaIk63WBGxe5Y220=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kfDoTLgVwiw3CPOXBfT1YqVUlJ2LFw2yS0huVGzuxQyGX6rYRzyV3VuYQu6fD/TZs6VP13dkDOipPUVsze/Nt4vr0BJ5w9oJbS74NvUR0D4o/1DIeRAXLPC3k9VlpkjqAOg5L+CxTeez+OrGT3Xr0iqNhx3x6MuC6/7gGk3az8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=gnumonks.org; arc=none smtp.client-ip=213.95.27.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gnumonks.org Received: from [78.30.37.63] (port=43634 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t1Pmg-00Eunf-4s; Thu, 17 Oct 2024 14:39:20 +0200 Date: Thu, 17 Oct 2024 14:39:17 +0200 From: Pablo Neira Ayuso To: Felix Fietkau Cc: Eric Woudstra , Nikolay Aleksandrov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jozsef Kadlecsik , Roopa Prabhu , Matthias Brugger , AngeloGioacchino Del Regno , Jiri Pirko , Sebastian Andrzej Siewior , Lorenzo Bianconi , Frank Wunderlich , Daniel Golle , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH RFC v1 net-next 00/12] bridge-fastpath and related improvements Message-ID: References: <20241013185509.4430-1-ericwouds@gmail.com> <9f9f3cf0-7a78-40f1-b8d5-f06a2d428210@blackwall.org> <0b0a92f2-2e80-429c-8fcd-d4dc162e6e1f@nbd.name> <137aa23a-db21-43c2-8fb0-608cfe221356@gmail.com> Precedence: bulk X-Mailing-List: bridge@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Score: -1.9 (-) On Thu, Oct 17, 2024 at 11:17:09AM +0200, Felix Fietkau wrote: [...] > By the way, based on some reports that I received, I do believe that the > existing forwarding fastpath also doesn't handle roaming properly. > I just didn't have the time to properly look into that yet. I think it should work for the existing forwarding fastpath. - If computer roams from different port, packets follow classic path, then new flow entry is created. The flow old entry expires after 30 seconds. - If route is stale, flow entry is also removed. Maybe I am missing another possible scenario? Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6204D37487 for ; Thu, 17 Oct 2024 12:50:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gYE2gysXr1blfj4n407WZybSRxm2Uc9PlWzDKaMkeJA=; b=Y7ghwbDLqmyqSt915qP3wcpGxY uWGjzEYJt3cwJXlK/vo5yoYQk/JI/f7i34sv+Re9nuX02TGACJ5FpKFwFFsonDB5uXYhdGW3ndvno NwnKOJqG0eujP2vDzccaLxsdsieDKDS2TromheL/e6CknZTrsX500kxPRTqKjHBZXQ859u9GzRTcU Z3ql7Oc/WpeqbnpNc5cW0nOLHfUKQyYrg85L8+euMDQsM9KNl61Pwij0cRGz5TK1L+N+Za3OsRoWR 31rlL3Jlw+t2z5OKIhN3yI7yUBlB/YvSqBsNYreBd+f88gzi/1k6sQqhngjVSmnNNhj9Iem0xvVD9 8Ox0B/8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t1Pxk-0000000Epma-0Wv6; Thu, 17 Oct 2024 12:50:44 +0000 Received: from ganesha.gnumonks.org ([2001:780:45:1d:225:90ff:fe52:c662]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t1Pmq-0000000EnZN-3pXy; Thu, 17 Oct 2024 12:39:30 +0000 Received: from [78.30.37.63] (port=43634 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t1Pmg-00Eunf-4s; Thu, 17 Oct 2024 14:39:20 +0200 Date: Thu, 17 Oct 2024 14:39:17 +0200 From: Pablo Neira Ayuso To: Felix Fietkau Subject: Re: [PATCH RFC v1 net-next 00/12] bridge-fastpath and related improvements Message-ID: References: <20241013185509.4430-1-ericwouds@gmail.com> <9f9f3cf0-7a78-40f1-b8d5-f06a2d428210@blackwall.org> <0b0a92f2-2e80-429c-8fcd-d4dc162e6e1f@nbd.name> <137aa23a-db21-43c2-8fb0-608cfe221356@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241017_053928_997584_6F3A8029 X-CRM114-Status: UNSURE ( 9.17 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nikolay Aleksandrov , Daniel Golle , Eric Dumazet , Jozsef Kadlecsik , coreteam@netfilter.org, Roopa Prabhu , Jakub Kicinski , Paolo Abeni , Lorenzo Bianconi , Sebastian Andrzej Siewior , Jiri Pirko , bridge@lists.linux.dev, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, Eric Woudstra , "David S. Miller" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Oct 17, 2024 at 11:17:09AM +0200, Felix Fietkau wrote: [...] > By the way, based on some reports that I received, I do believe that the > existing forwarding fastpath also doesn't handle roaming properly. > I just didn't have the time to properly look into that yet. I think it should work for the existing forwarding fastpath. - If computer roams from different port, packets follow classic path, then new flow entry is created. The flow old entry expires after 30 seconds. - If route is stale, flow entry is also removed. Maybe I am missing another possible scenario? Thanks.