All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, Jordy Zomer <jordyzomer@google.com>,
	Josh Poimboeuf <jpoimboe@kernel.org>
Subject: Re: [PATCH] cdrom: Avoid barrier_nospec() in cdrom_ioctl_media_changed()
Date: Fri, 18 Oct 2024 11:31:24 +0100	[thread overview]
Message-ID: <ZxI4_BlGL99OX7b4@equinox> (raw)
In-Reply-To: <172921605188.361223.17436309372879358744.b4-ty@kernel.dk>

On Thu, Oct 17, 2024 at 07:47:31PM -0600, Jens Axboe wrote:
> 
> On Thu, 17 Oct 2024 15:09:02 -0700, Josh Poimboeuf wrote:
> > The barrier_nospec() after the array bounds check is overkill and
> > painfully slow for arches which implement it.
> > 
> > Furthermore, most arches don't implement it, so they remain exposed to
> > Spectre v1 (which can affect pretty much any CPU with branch
> > prediction).
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] cdrom: Avoid barrier_nospec() in cdrom_ioctl_media_changed()
>       commit: b0bf1afde7c34698cf61422fa8ee60e690dc25c3
> 
> Best regards,
> -- 
> Jens Axboe
> 
> 
> 

Sorry for lack of reply, this conversation took place in the early hours
for my timezone and thus I was unconscious :-)

Change sounds good to me for the aforementioned reasons.

Regards,
Phil

      reply	other threads:[~2024-10-18 10:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17 22:09 [PATCH] cdrom: Avoid barrier_nospec() in cdrom_ioctl_media_changed() Josh Poimboeuf
2024-10-18  0:33 ` Jens Axboe
2024-10-18  0:52   ` Josh Poimboeuf
2024-10-18  1:10     ` Jens Axboe
2024-10-18  1:47 ` Jens Axboe
2024-10-18 10:31   ` Phillip Potter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZxI4_BlGL99OX7b4@equinox \
    --to=phil@philpotter.co.uk \
    --cc=axboe@kernel.dk \
    --cc=jordyzomer@google.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.