From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [PATCH] stubs: remove stubs/qdev.c
Date: Sat, 19 Oct 2024 00:44:43 +0800 [thread overview]
Message-ID: <ZxKQe1LesrnYbCSa@intel.com> (raw)
In-Reply-To: <20241018143334.949045-1-pbonzini@redhat.com>
On Fri, Oct 18, 2024 at 04:33:33PM +0200, Paolo Bonzini wrote:
> Date: Fri, 18 Oct 2024 16:33:33 +0200
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH] stubs: remove stubs/qdev.c
> X-Mailer: git-send-email 2.46.2
>
> qapi_event_send_device_deleted is always included (together
> with the rest of QAPI) in libqemuutil.a, so it is unnecessary
> to include a stub for it.
>
> This avoids a duplicate symbol in libqemuutil.a, which in
> principle could result in missing events on the monitor.
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> stubs/qdev.c | 22 ----------------------
> stubs/meson.build | 1 -
> 2 files changed, 23 deletions(-)
> delete mode 100644 stubs/qdev.c
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
prev parent reply other threads:[~2024-10-18 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 14:33 [PATCH] stubs: remove stubs/qdev.c Paolo Bonzini
2024-10-18 16:44 ` Zhao Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxKQe1LesrnYbCSa@intel.com \
--to=zhao1.liu@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.