Re: [PATCH v4 2/3] iommu/arm-smmu-v3: Log better event records

[Pranjal Shrivastava <praan@google.com>]

On Fri, Oct 18, 2024 at 09:51:40PM -0700, Nicolin Chen wrote:
> On Fri, Oct 18, 2024 at 07:06:49PM -0700, Nicolin Chen wrote:
> > > +                       put_device(evt.dev);
> > 
> > then, here it puts unconditionally.
> > 
> > Maybe we do need a memset(0) to the event, then here
> >                         if (evet.dev)
> >                                 put_device(evt.dev);
> 
> Oh, put_device does that already. So we are fine here. Pls ignore.

Yes. Ack.

> 
> With the other two nits, it looks good to me,
> Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
> 
> Nicolin

Thanks
Pranjal