From: Patrick Steinhardt <ps@pks.im>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Edgar Bonet <bonet@grenoble.cnrs.fr>,
Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: clar unit testing framework FTBFS on uclibc systems (wchar_t unsupported)
Date: Mon, 21 Oct 2024 08:44:50 +0200 [thread overview]
Message-ID: <ZxX4YtZ5lW0axToT@pks.im> (raw)
In-Reply-To: <ZxJnfYtuxnAEBc1E@archie.me>
On Fri, Oct 18, 2024 at 08:49:49PM +0700, Bagas Sanjaya wrote:
> On Thu, Oct 17, 2024 at 03:54:28PM +0200, Patrick Steinhardt wrote:
[snip]
> On Buildroot site, Edgar Bonet (Cc:'ed) suggests to improve your patch by
> wrapping strcmps [1]:
Thanks. So with the proposed patch things work?
One thing I still don't understand: why don't you get an error from
includeng <wchar.h>? As shown above, it should contain the following
snippet:
> > #ifndef __UCLIBC_HAS_WCHAR__
> > #error Attempted to include wchar.h when uClibc built without wide char support.
> > #endif
So I'd expect that to trigger and cause the build to abort. Am I missing
anything here? Let me have another look at uclibc...
Oh, yes! There's also a "wchar-stub.h" file that replaces "wchar.h" when
compiled without UCLIBC_HAS_WCHAR=Yes. And that file indeed does not
cause us to error out, but is a stub. It also explains why the logs do
not complain about the missing `wchar_t` type, as that type does get
defined by the stub header. Weird, but so be it.
I've picked this up upstream via [1].
[1]: https://github.com/clar-test/clar/pull/108
Patrick
prev parent reply other threads:[~2024-10-21 6:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 3:51 clar unit testing framework FTBFS on uclibc systems (wchar_t unsupported) Bagas Sanjaya
2024-10-17 13:33 ` Patrick Steinhardt
2024-10-17 13:54 ` Patrick Steinhardt
2024-10-17 20:08 ` Taylor Blau
2024-10-17 22:21 ` brian m. carlson
2024-10-18 4:51 ` Jeff King
2024-10-18 4:59 ` Patrick Steinhardt
2024-10-18 5:24 ` Jeff King
2024-10-18 5:31 ` Patrick Steinhardt
2024-10-18 20:50 ` Taylor Blau
2024-10-21 6:44 ` Patrick Steinhardt
2024-10-21 19:30 ` Jeff King
2024-10-21 19:41 ` Taylor Blau
2024-10-18 20:07 ` brian m. carlson
2024-10-21 19:19 ` Jeff King
2024-10-21 19:31 ` Jeff King
2024-10-18 13:49 ` Bagas Sanjaya
2024-10-21 6:44 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxX4YtZ5lW0axToT@pks.im \
--to=ps@pks.im \
--cc=bagasdotme@gmail.com \
--cc=bonet@grenoble.cnrs.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.