Re: [RFC V1 13/14] net: cleanup for precreate phase

[Peter Xu <peterx@redhat.com>]

On Thu, Oct 17, 2024 at 08:14:14AM -0700, Steve Sistare wrote:
> Guard against unconfigured state if cleanup is called early, such as
> during the precreate phase.
> 
> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

One nitpick..

> ---
>  net/net.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/net/net.c b/net/net.c
> index d9b23a8..207fdb0 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -1687,7 +1687,9 @@ void net_cleanup(void)
>          }
>      }
>  
> -    qemu_del_vm_change_state_handler(net_change_state_entry);
> +    if (net_change_state_entry) {
> +        qemu_del_vm_change_state_handler(net_change_state_entry);

Can also rest net_change_state_entry to NULL.

> +    }
>  }
>  
>  void net_check_clients(void)
> -- 
> 1.8.3.1
> 

-- 
Peter Xu