From: Roman Gushchin <roman.gushchin@linux.dev>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Vlastimil Babka <vbabka@suse.cz>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH v2] mm: page_alloc: move mlocked flag clearance into free_pages_prepare()
Date: Tue, 22 Oct 2024 02:14:39 +0000 [thread overview]
Message-ID: <ZxcKjwhMKmnHTX8Q@google.com> (raw)
In-Reply-To: <Zxa60Ftbh8eN1MG5@casper.infradead.org>
On Mon, Oct 21, 2024 at 09:34:24PM +0100, Matthew Wilcox wrote:
> On Mon, Oct 21, 2024 at 05:34:55PM +0000, Roman Gushchin wrote:
> > Fix it by moving the mlocked flag clearance down to
> > free_page_prepare().
>
> Urgh, I don't like this new reference to folio in free_pages_prepare().
> It feels like a layering violation. I'll think about where else we
> could put this.
I agree, but it feels like it needs quite some work to do it in a nicer way,
no way it can be backported to older kernels. As for this fix, I don't
have better ideas...
next prev parent reply other threads:[~2024-10-22 2:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 17:34 [PATCH v2] mm: page_alloc: move mlocked flag clearance into free_pages_prepare() Roman Gushchin
2024-10-21 17:57 ` Shakeel Butt
2024-10-22 2:11 ` Roman Gushchin
2024-10-21 19:49 ` Hugh Dickins
2024-10-22 2:16 ` Roman Gushchin
2024-11-06 1:09 ` Sean Christopherson
2024-11-06 1:32 ` Roman Gushchin
2024-11-06 2:19 ` Hugh Dickins
2024-10-21 20:34 ` Matthew Wilcox
2024-10-21 21:14 ` Hugh Dickins
2024-10-22 2:14 ` Roman Gushchin [this message]
2024-10-22 3:47 ` Matthew Wilcox
2024-10-22 4:33 ` Roman Gushchin
2024-10-22 8:26 ` Yosry Ahmed
2024-10-22 15:39 ` Sean Christopherson
2024-10-22 16:59 ` Matthew Wilcox
2024-10-22 19:52 ` Sean Christopherson
2024-10-23 2:04 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxcKjwhMKmnHTX8Q@google.com \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.