From: Taylor Blau <me@ttaylorr.com>
To: Caleb White <cdwhite3@pm.me>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] doc: consolidate extensions in git-config documentation
Date: Tue, 22 Oct 2024 13:13:10 -0400 [thread overview]
Message-ID: <ZxfdJs5+YbpHgpdv@nand.local> (raw)
In-Reply-To: <20241021-cleanup-extension-docs-v1-1-ab02cece3132@pm.me>
On Tue, Oct 22, 2024 at 12:08:49AM +0000, Caleb White wrote:
> diff --git a/Documentation/config/extensions.txt b/Documentation/config/extensions.txt
> index f0a784447db09856639ec43b443681f13c17c966..5dc569d1c9c77c15e32441493289f9c9dd5e7f0b 100644
> --- a/Documentation/config/extensions.txt
> +++ b/Documentation/config/extensions.txt
> @@ -1,17 +1,13 @@
> -extensions.objectFormat::
> - Specify the hash algorithm to use. The acceptable values are `sha1` and
> - `sha256`. If not specified, `sha1` is assumed. It is an error to specify
> - this key unless `core.repositoryFormatVersion` is 1.
> +extensions.*::
> + Unless otherwise stated, is an error to specify an extension if
> + `core.repositoryFormatVersion` is not `1`. See
> + linkgit:gitrepository-layout[5].
> +
> -Note that this setting should only be set by linkgit:git-init[1] or
> -linkgit:git-clone[1]. Trying to change it after initialization will not
> -work and will produce hard-to-diagnose issues.
> -
> -extensions.compatObjectFormat::
> -
> +--
> +compatObjectFormat::
Should this be `extensions.compatObjectFormat` instead of
`compatObjectFormat`? I think the latter will produce awkward headings
when these all get merged into git-config(1).
Otherwise, looking good. Thanks for working on this!
Thanks,
Taylor
next prev parent reply other threads:[~2024-10-22 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 0:08 [PATCH] doc: consolidate extensions in git-config documentation Caleb White
2024-10-22 17:13 ` Taylor Blau [this message]
2024-10-22 17:33 ` Caleb White
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxfdJs5+YbpHgpdv@nand.local \
--to=me@ttaylorr.com \
--cc=cdwhite3@pm.me \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.