Re: [PATCH 6/6] usdt: fix create_underlying error path

[Kris Van Hees <kris.van.hees@oracle.com>]

On Fri, Oct 18, 2024 at 08:58:08PM +0100, Nick Alcock wrote:
> On error, we were destroying the underlying probe using the wrong call,
> as if it were an overlying probe.
> 
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  libdtrace/dt_prov_uprobe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libdtrace/dt_prov_uprobe.c b/libdtrace/dt_prov_uprobe.c
> index 767d9a80b5e1..83d6f65a5207 100644
> --- a/libdtrace/dt_prov_uprobe.c
> +++ b/libdtrace/dt_prov_uprobe.c
> @@ -274,7 +274,7 @@ static dt_probe_t *create_underlying(dtrace_hdl_t *dtp,
>  	return uprp;
>  
>  fail:
> -	probe_destroy(dtp, upp);
> +	probe_destroy_underlying(dtp, upp);
>  	return NULL;
>  }
>  
> -- 
> 2.46.0.278.g36e3a12567
>